-
Notifications
You must be signed in to change notification settings - Fork 1.6k
RFC: #[cfg(version_since(rust, "1.95"))] for Rust-version conditional compilation
#3857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
epage
wants to merge
109
commits into
rust-lang:master
Choose a base branch
from
epage:cfg_version
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,051
−0
Open
Changes from 1 commit
Commits
Show all changes
109 commits
Select commit
Hold shift + click to select a range
4dbd2d2
Fork cfg_version v2 skeleton
epage ecb3459
Initial draft
epage 236f2a5
Rename the version predicate to since
epage 2ee3718
Rename file for RFC #
epage 20233b0
Link out to the RFC
epage 3d827bc
Add another problem with vendor version
epage a24a6a4
Fix grammar
epage 5a7c0e9
Fix grammar
epage d392d50
Clean up a sentence
epage e51caf2
Remove behavior left behind from a previous iteration
epage cb8acba
Revert "Remove behavior left behind from a previous iteration"
epage a1a8164
Update Guide to reflect how nightlies are proposed
epage c5e9d5f
Misc cleanup
epage 465cecc
Update text/3857-cfg-version.md
epage 0fed553
Fix grammar
epage 3a7609a
Unquoted versions may negstively interact with target_version
epage 55a7632
Fix unclosed literal
epage 545ef52
Add counter balance to build probe drawback
epage 4352a95
Clarify Python's post-release version comment
epage c0a7dc4
Fix grammar
epage ce77858
Fix print=cfg syntax
epage 7ba5578
Fix print=cfg syntax
epage 0d7f46c
Clarify check-cfg
epage b2e8cdb
Clarify the alternatives for check-cfg
epage 50e6949
Provide unique anchors
epage 2348d45
Future possibility for check-cfg version without a minimum
epage 6f656d5
fix(drawback): Simplify nightly discussion
epage 21b8dc0
fix(ref): Draw more attention to the warnings when discussion cfg
epage ee1c8cf
fix(guide): Fix bad versions and try to clarify example
epage ec2e54c
feat(rationale): Cover before
epage 96ffa15
feat(drawbacks): Cover pre-releases of major versions
epage a07e1c6
fix(summary): Be name the predicate being added
epage c386700
fix(drawbacks): Tweak language around cargo requiring msrv bump for s…
epage 741f854
fix(drawback): Be explicit on why -0 is chosen for the recommendation…
epage 5ee6b1e
feat(prior): Include swift
epage 95c2998
feat(ref): Discuss usability improvement to check-cfg warning
epage 1b8355a
refactor(future): Group related items
epage 0ab2847
fix: Update ConfigurationVersion for the rename to 'since'
epage f1dedc5
feat(future): Add an is_set predicate which came up while working on …
epage 7139923
fix: Introduce has_rust to replace incorrect use of cfg(rust)
epage e71bdc1
fix(future): Include alternate name for 'before'
epage c12e4a4
Revert "fix: Introduce has_rust to replace incorrect use of cfg(rust)"
epage 28b52e1
fix: Workaround #[cfg(rust)] with --cfg rust
epage b445f73
refactor(ref):? Include rust's --check-cfg in the rust-specific section
epage 5eef426
fix(ref): Be more precise when talking about check-cfg
epage 9da21e1
fix(ref): Correct where we cross-link check-cfg for since
epage d27c10d
fix(ref): Separate since logic for unset/name-only
epage 0a839bd
fix(rationale): Acknowledge impact of cfg(rust) on cfg_value
epage 005c608
fix(ref): Specify when multiple cfg's are present for the same name
epage 5d01721
style: Fix spelling
epage e036b23
style: Be more consistent in quoting
epage 940b979
fix(ref): Turn non-semver 'since' from false to error
epage b37fe10
feat(future): Speak to how `edition` would work
epage 2c3cbe4
fix(drawbacks): Speak to general vs specialized solutions
epage 75c486b
fix(rationale): Include another benefit for non-semver erroring
epage 602eec6
fix(ref): Syntax error
epage e352338
fix(rationale): Cover a little more about extending version syntax
epage 995eeed
fix(future): Discuss a slow roll out of relaxing version definition
epage c7ebc40
fix(alt): Cover has_rust
epage 679116a
fix(alt): Include cfg rust_version name
epage 5accada
feat(unresolved): Call out main T-lang questions within RFC
epage 19dca3e
feat(alt): Add an operator variant
epage 12f6745
feat(unresolved): Include discussion of nightlies
epage 303bb64
style: Try to fix formatting
epage 4347c60
fix(ref): Update examples for changes to compiler errors
epage 53e0d39
fix(ref): Address a cardinality issue
epage 8a57b6b
fix(summary): Fully specify the cfg
epage 97d86b6
fix(motivation): Re-order for clarity
epage 6241a5d
style: Fix grammar
epage 955a11e
fix(ref): Remove a line from before bad string literals errored
epage 3e89ae8
fix(ref): Delegate to SemVer, rather than Cargo, on comparisons
epage e544016
fix(ref): Clarify use of +build
epage 3e632bf
fix(rationale): Further clarify +build
epage 5b9fefe
fix(ref): Be consistent with +build
epage 1024808
fix(rationale): Explain lack of +build for check-cfg
epage 4031627
fix(ref): Be consistent with string literal
epage 2bbed78
fix(ref): Clarify unexpected_cfgs
epage 56305c3
fix(unresolved): Discusss pre-release name
epage 7561a72
fix(drawback): Add findings on use of --cfg rust
epage fed559b
fix(drawback): Add context to the not(since) concern
epage 459c87b
style(drawback): Fix grammar
epage dbbcab4
style(drawback): Fill in assumed gaps about generality
epage bc71f84
feat(alt): Cover version(since)
epage 94d2438
style: Fix typo
epage b3b7c76
style: Grammar
epage be317a1
style: Grammar
epage 851d2ed
fix(ref): Remove stale reference to invalid string literals being false
epage f461c5b
feat(unresolved): Call out decision on betas and incomplete
epage 102adb1
fix: Use shorthand for values(none())
epage 83a393c
fix(unresolved): Decide on values(none())
epage fb896af
feat(rationale): Cover more trade offs for `values(none())`
epage 18a9594
style: Fix spelling
epage f3b4a69
fix(future): Correct sorting of post releases
epage ae5822c
fix(rationale): Clarify about since name
epage 6b7ec78
feat(rationale): Cover since evaluting to false
epage 1589434
feat(alt): Add unresolved question for operators in version()
epage cab1e93
style(unresolved): Fix spelling
epage 674ec04
feat(alt): Cover typing/operator overloading
epage be94add
fix(alt): Alude to implicit type support
epage 79f50aa
feat(alt): Bring up possible check-cfg syntax
epage 3f765c1
feat(future): Clippy lint to use since with cfg_alias
epage 56ddfc3
fix(ref): Nightly and beta are incomplete
epage 3519b83
style: Fix typo
epage b3bff0f
fix(ref): Drop patch, specify Version syntax and precedence
epage b4338cb
feat(alt): Problem with future possibilities and operators
epage 6703ecd
fix(ref): Be more precise in the name with version_since
epage ff3f075
feat(alt): Provide another reason for version(since)
epage ce9390b
feat(rationale): More reasons for version_since than since_version
epage d089ddd
feat(alt): Cover more operator concerns
epage File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Clarify check-cfg
- Loading branch information
commit 0d7f46ce8e4cb868aca0a240ba6ade0e17fb71be
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.