Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Improve crate selection on rustdoc search results page #100374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 12, 2022
Merged

Improve crate selection on rustdoc search results page #100374

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
16bcc18
Improve crate selection on rustdoc search results page
steffahn Jul 3, 2022
e957480
Two small improvements:
steffahn Jul 11, 2022
107e039
Add missing ID into the ID map
GuillaumeGomez Aug 10, 2022
ea05be2
Update GUI test
GuillaumeGomez Aug 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update GUI test
  • Loading branch information
@GuillaumeGomez
GuillaumeGomez committed Aug 10, 2022
commit ea05be2cf8b2e38dd0f0607c9b6e9ec048a8b3f7
46 changes: 14 additions & 32 deletions src/test/rustdoc-gui/search-result-display.goml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ size: (900, 1000)
write: (".search-input", "test")
// To be SURE that the search will be run.
press-key: 'Enter'
wait-for: ".search-results-title"
wait-for: "#crate-search"
// The width is returned by "getComputedStyle" which returns the exact number instead of the
// CSS rule which is "50%"...
assert-css: (".search-results div.desc", {"width": "295px"})
Expand All @@ -17,36 +17,18 @@ assert-css: (".search-results div.desc", {"width": "570px"})
// To do so we need to update the length of one of its `<option>`.
size: (900, 900)

// First we check the current width and position.
assert-css: ("#crate-search", {"width": "218px"})
compare-elements-position-near: (
"#crate-search",
".search-results-title",
{"y": 5},
)
// First we check the current width, height and position.
assert-css: ("#crate-search", {"width": "223px"})
assert-css: (".search-results-title", {"height": "44px", "width": "336px"})

// FIXME: Fix and re-enable these tests!
// Then we update the text of one of the `<option>`.
text: (
"#crate-search option",
"sdjfaksdjfaksjdbfkadsbfkjsadbfkdsbkfbsadkjfbkdsabfkadsfkjdsafa",
)

// // First we check the current width and position.
// assert-css: ("#crate-search", {"width": "222px"})
// compare-elements-position-near: (
// "#crate-search",
// "#search-settings .search-results-title",
// {"y": 5},
// )
//
// // Then we update the text of one of the `<option>`.
// text: (
// "#crate-search option",
// "sdjfaksdjfaksjdbfkadsbfkjsadbfkdsbkfbsadkjfbkdsabfkadsfkjdsafa",
// )
//
// // Then we compare again.
// assert-css: ("#crate-search", {"width": "640px"})
// compare-elements-position-near-false: (
// "#crate-search",
// "#search-settings .search-results-title",
// {"y": 5},
// )
// // And we check that the `<select>` isn't bigger than its container.
// assert-css: ("#search", {"width": "640px"})
// Then we compare again to confirm the height didn't change.
assert-css: ("#crate-search", {"width": "527px"})
assert-css: (".search-results-title", {"height": "44px", "width": "640px"})
// And we check that the `<select>` isn't bigger than its container (".search-results-title").
assert-css: ("#search", {"width": "640px"})