Thanks to visit codestin.com
Credit goes to github.com

Skip to content

rustc_parse: diagnostics migration, v4 #105670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Feb 2, 2023
Merged

rustc_parse: diagnostics migration, v4 #105670

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
f2acbb9
Forbid #[suggestion_*(...)] on Vecs
Xiretza Oct 16, 2022
0e36e7c
rustc_parse: avoid creating unnecessary intermediate strings
Xiretza Dec 27, 2022
fc0ba2c
Use AddToDiagnostic for "use latest edition" help
Xiretza Oct 5, 2022
a84adba
Implement IntoDiagnosticArg for ast::Visibility
Xiretza Oct 5, 2022
0757d5f
Fix condition for "missing `struct`" diagnostic on tuple structs
Xiretza Oct 6, 2022
ac9c66b
tests: rename test cases to match new behaviour
Xiretza Dec 27, 2022
87ef37d
rustc_parse: migrate more to diagnostic structs
Xiretza Oct 14, 2022
9564a30
Convert rustc_parse::parser::pat::Expected to enum
Xiretza Nov 8, 2022
7631b12
migrate parser::ty to diagnostic structs
Xiretza Oct 18, 2022
a476683
rustc_parse: revert conversion of "non-item in item list" diagnostic
Xiretza Dec 13, 2022
0d0d369
Make "use latest edition" subdiagnostic translatable
Xiretza Dec 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
rustc_parse: avoid creating unnecessary intermediate strings
  • Loading branch information
@Xiretza
Xiretza committed Feb 1, 2023
commit 0e36e7cebe4db494478982f80db2f928f59802d6
3 changes: 2 additions & 1 deletion compiler/rustc_parse/src/parser/item.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ use rustc_span::lev_distance::lev_distance;
use rustc_span::source_map::{self, Span};
use rustc_span::symbol::{kw, sym, Ident, Symbol};
use rustc_span::DUMMY_SP;
use std::fmt::Write;
use std::mem;
use thin_vec::ThinVec;

Expand Down Expand Up @@ -1109,7 +1110,7 @@ impl<'a> Parser<'a> {
let fixed_name_sp = ident.span.to(idents.last().unwrap().span);
let mut fixed_name = ident.name.to_string();
for part in idents {
fixed_name.push_str(&format!("_{}", part.name));
write!(fixed_name, "_{}", part.name).unwrap();
}
ident = Ident::from_str_and_span(&fixed_name, fixed_name_sp);

Expand Down