Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

c410-f3r
Copy link
Contributor

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 18, 2023
@petrochenkov
Copy link
Contributor

issue-32709.rs -> try_trait (span is a meaningless subdirectory)
issue-3707.rs -> methods, I guess
issue-34721.rs -> moves (suggestions is a meaningless subdirectory)
issue-69225-SCEVAddExpr-wrap-flag.rs -> loops
issue-69225-layout-repeated-checked-add.rs -> loops
@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 19, 2023
@bors

This comment was marked as resolved.

@bors

This comment was marked as resolved.

@c410-f3r
Copy link
Contributor Author

Done

@bors

This comment was marked as resolved.

@petrochenkov
Copy link
Contributor

r=me after rebase.

@c410-f3r
Copy link
Contributor Author

Done

@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 29, 2023

📌 Commit 5a69151 has been approved by petrochenkov

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 29, 2023
@bors
Copy link
Collaborator

bors commented Aug 29, 2023

⌛ Testing commit 5a69151 with merge bb90f81...

@bors
Copy link
Collaborator

bors commented Aug 29, 2023

☀️ Test successful - checks-actions
Approved by: petrochenkov
Pushing bb90f81 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 29, 2023
@bors bors merged commit bb90f81 into rust-lang:master Aug 29, 2023
@rustbot rustbot added this to the 1.74.0 milestone Aug 29, 2023
@bors bors mentioned this pull request Aug 29, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (bb90f81): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
2.8% [2.8%, 2.8%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-0.6% [-0.6%, -0.6%] 1
Improvements ✅
(secondary)
-2.5% [-2.5%, -2.5%] 1
All ❌✅ (primary) 1.1% [-0.6%, 2.8%] 2

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 630.483s -> 630.431s (-0.01%)
Artifact size: 316.05 MiB -> 315.96 MiB (-0.03%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants