Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Make AIX known by bootstrap #115811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 18, 2023
Merged

Make AIX known by bootstrap #115811

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2962528
Make AIX known by bootstrap
Sep 13, 2023
fc17e09
Add comment to elaborate
Sep 13, 2023
5049a71
Adjust comment
Sep 13, 2023
122d1cc
Adjust comment
Sep 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Adjust comment
  • Loading branch information
Kai Luo committed Sep 13, 2023
commit 122d1cc8c332b4dd176e1475a063688e73d95168
4 changes: 2 additions & 2 deletions src/bootstrap/bootstrap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,9 +314,9 @@ def default_build_triple(verbose):
return 'x86_64-pc-windows-msvc'
elif kernel == 'AIX':
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make more sense to add AIX to the kerneltype map above?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added comment to describe the reason :).

# `uname -m` returns the machine ID rather than machine hardware on AIX,
# so we are unable to use cputype to form triple. Since AIX 7.2 and
# so we are unable to use cputype to form triple. AIX 7.2 and
# above supports 32-bit and 64-bit mode simultaneously and `uname -p`
# returns `powerpc`. Currently we only supports `powerpc64-ibm-aix` in
# returns `powerpc`, however we only supports `powerpc64-ibm-aix` in
# rust on AIX. For above reasons, kerneltype_mapper and cputype_mapper
# are not used to infer AIX's triple.
return 'powerpc64-ibm-aix'
Expand Down