Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Tweak .clone() suggestion to work in more cases #118076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Dec 5, 2023
Merged

Tweak .clone() suggestion to work in more cases #118076

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
03c88aa
Tweak `.clone()` suggestion to work in more cases
estebank Nov 19, 2023
98cfed7
Suggest cloning and point out obligation errors on move error
estebank Nov 20, 2023
90db536
Tweak output on specific case
estebank Nov 20, 2023
1c69c6a
Mark more tests as `run-rustfix`
estebank Nov 20, 2023
a754fca
On "this .clone() is on the reference", provide more info
estebank Nov 21, 2023
210a672
Deduplicate some logic
estebank Nov 21, 2023
cc80106
Provide more suggestions for cloning immutable bindings
estebank Nov 21, 2023
a8faa82
Fix rebase
estebank Dec 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix rebase
  • Loading branch information
@estebank
estebank committed Dec 4, 2023
commit a8faa8288c5823195cf4e7b0de8eab06aa3f2ebb
2 changes: 1 addition & 1 deletion tests/ui/moves/assignment-of-clone-call-on-ref-due-to-missing-bound.stderr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,6 @@ LL + #[derive(Clone)]
LL | enum Day {
|

error: aborting due to previous error
error: aborting due to 1 previous error

For more information about this error, try `rustc --explain E0308`.
2 changes: 1 addition & 1 deletion tests/ui/moves/needs-clone-through-deref.stderr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,6 @@ help: you can `clone` the value and consume it, but this might not be your desir
LL | for _ in <Vec<usize> as Clone>::clone(&self.clone()).into_iter() {}
| ++++++++++++++++++++++++++++++ +

error: aborting due to previous error
error: aborting due to 1 previous error

For more information about this error, try `rustc --explain E0507`.
2 changes: 1 addition & 1 deletion tests/ui/moves/suggest-clone-when-some-obligation-is-unmet.stderr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,6 @@ LL + #[derive(Clone)]
LL | pub struct Hash128_1;
|

error: aborting due to previous error
error: aborting due to 1 previous error

For more information about this error, try `rustc --explain E0507`.