Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

ecnelises
Copy link
Contributor

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Nov 20, 2023

r? @Kobzol

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Nov 20, 2023
@Kobzol
Copy link
Member

Kobzol commented Nov 20, 2023

Hi, could you please provide a bit of context to this PR, like why was this change made? Thanks! :)

@ecnelises
Copy link
Contributor Author

Hi, this is from briansmith/ring#1679 . I'd like to add profiler builtin to CI build of powerpc64-linux (and powerpc-linux). Since powerpc64le-linux and other mainstream targets already have --enable-profiler in build flags, this will not bring maintainance burden I think.

I verified it from a cross build from x86_64-linux to powerpc64-linux and it generates LLVM profdata as expected.

@Kobzol
Copy link
Member

Kobzol commented Nov 22, 2023

Oh, I see that it's indeed already enabled for le PowerPC. Then this is fine. Feel free to send another PR for powerpc if you also need it.

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Nov 22, 2023

📌 Commit 244e181 has been approved by Kobzol

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 22, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 22, 2023
…mpiler-errors

Rollup of 6 pull requests

Successful merges:

 - rust-lang#118012 (Add support for global allocation in smir)
 - rust-lang#118013 (Enable Rust to use the EHCont security feature of Windows)
 - rust-lang#118100 (Enable profiler in dist-powerpc64-linux)
 - rust-lang#118142 (Tighten up link attributes for llvm-wrapper bindings)
 - rust-lang#118147 (Fix some unnecessary casts)
 - rust-lang#118161 (Allow defining opaques in `check_coroutine_obligations`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 90f04e1 into rust-lang:master Nov 22, 2023
@rustbot rustbot added this to the 1.76.0 milestone Nov 22, 2023
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Nov 22, 2023
Rollup merge of rust-lang#118100 - ecnelises:ppc64_profiler, r=Kobzol

Enable profiler in dist-powerpc64-linux
@ecnelises
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants