Don't ICE when non-self part of trait goal is constrained in new solver #122319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some changes occurred to the core trait solver cc @rust-lang/initiative-trait-system-refactor |
lcnr
reviewed
Mar 11, 2024
| // This goal is also possible w/ a GAT, but lazy_type_alias | ||
| // makes the behavior a bit more readable. | ||
| #![feature(lazy_type_alias)] | ||
| //~^ WARN the feature `lazy_type_alias` is incomplete |
There was a problem hiding this comment.
Suggested change
| //~^ WARN the feature `lazy_type_alias` is incomplete | |
| #![allow(incomplete_features)] |
There was a problem hiding this comment.
I actually quite like the explicit warn since it'll cause an error (and force it to be removed) when the feature is marked as not-incomplete -- rather than having this allow stay around forever.
tests/ui/traits/next-solver/normalize-self-type-constrains-trait-args.rs
Show resolved
Hide resolved
a8ac4cc to
0b6b330
Compare
|
If you strongly disagree w #106527 (comment), then I can update it in a follow-up, but for now @bors r=lcnr |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 11, 2024
…izing-self-constrains-args, r=lcnr Don't ICE when non-self part of trait goal is constrained in new solver Self-explanatory. See test for example when this can happen.
This was referenced Mar 11, 2024
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 12, 2024
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#115141 (Update Windows platform support) - rust-lang#121865 (Add FileCheck annotations to MIR-opt unnamed-fields tests) - rust-lang#122000 (Fix 32-bit overflows in LLVM composite constants) - rust-lang#122194 (Enable creating backtraces via -Ztreat-err-as-bug when stashing errors) - rust-lang#122319 (Don't ICE when non-self part of trait goal is constrained in new solver) - rust-lang#122339 (Update books) - rust-lang#122342 (Update /NODEFAUTLIB comment for msvc) - rust-lang#122343 (Remove some unnecessary `allow(incomplete_features)` in the test suite) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 12, 2024
Rollup merge of rust-lang#122319 - compiler-errors:next-solver-normalizing-self-constrains-args, r=lcnr Don't ICE when non-self part of trait goal is constrained in new solver Self-explanatory. See test for example when this can happen.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Self-explanatory. See test for example when this can happen.