Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Expand for_loops_over_fallibles lint to lint on fallibles behind references. #125156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 23, 2024
Merged

Expand for_loops_over_fallibles lint to lint on fallibles behind references. #125156

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
4be041a
Also apply `warn(for_loops_over_fallibles)` to &T and &mut T, not jus…
zachs18 May 15, 2024
7d7eb97
Fix new for_loops_over_fallibles hits in compiler.
zachs18 May 15, 2024
77f288c
Include reference in lint diagnostic
zachs18 May 15, 2024
ea549fd
Add tests for 'Also apply `warn(for_loops_over_fallibles)` to &T and …
zachs18 May 15, 2024
0e46759
Fix more new for_loops_over_fallibles hits in compiler.
zachs18 May 15, 2024
66573b7
Use 'a' article for &Option.
zachs18 May 15, 2024
6b818dd
Fix article in test
zachs18 May 15, 2024
376a8c0
Allow for_loops_over_fallibles in test that tests &mut Result as Into…
zachs18 May 15, 2024
a59d071
Fix `for_loops_over_fallibles` hits in compiletest/src/json.rs
zachs18 May 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix new for_loops_over_fallibles hits in compiler.
  • Loading branch information
@zachs18
zachs18 committed May 15, 2024
commit 7d7eb973d0118a52209e5ee7adafc29b341957f0
4 changes: 2 additions & 2 deletions compiler/rustc_builtin_macros/src/deriving/default.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ use crate::deriving::generic::*;
use crate::errors;
use core::ops::ControlFlow;
use rustc_ast as ast;
use rustc_ast::visit::walk_list;
use rustc_ast::visit::visit_opt;
use rustc_ast::{attr, EnumDef, VariantData};
use rustc_expand::base::{Annotatable, DummyResult, ExtCtxt};
use rustc_span::symbol::Ident;
Expand Down Expand Up @@ -224,7 +224,7 @@ impl<'a, 'b> rustc_ast::visit::Visitor<'a> for DetectNonVariantDefaultAttr<'a, '
self.visit_ident(v.ident);
self.visit_vis(&v.vis);
self.visit_variant_data(&v.data);
walk_list!(self, visit_anon_const, &v.disr_expr);
visit_opt!(self, visit_anon_const, &v.disr_expr);
for attr in &v.attrs {
rustc_ast::visit::walk_attribute(self, attr);
}
Expand Down
8 changes: 4 additions & 4 deletions compiler/rustc_resolve/src/late.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ use crate::{Module, ModuleOrUniformRoot, NameBinding, ParentScope, PathResult};
use crate::{ResolutionError, Resolver, Segment, UseError};

use rustc_ast::ptr::P;
use rustc_ast::visit::{walk_list, AssocCtxt, BoundKind, FnCtxt, FnKind, Visitor};
use rustc_ast::visit::{visit_opt, walk_list, AssocCtxt, BoundKind, FnCtxt, FnKind, Visitor};
use rustc_ast::*;
use rustc_data_structures::fx::{FxHashMap, FxHashSet, FxIndexMap};
use rustc_errors::{codes::*, Applicability, DiagArgValue, IntoDiagArg, StashKey};
Expand Down Expand Up @@ -3286,7 +3286,7 @@ impl<'a: 'ast, 'b, 'ast, 'tcx> LateResolutionVisitor<'a, 'b, 'ast, 'tcx> {
fn resolve_local(&mut self, local: &'ast Local) {
debug!("resolving local ({:?})", local);
// Resolve the type.
walk_list!(self, visit_ty, &local.ty);
visit_opt!(self, visit_ty, &local.ty);

// Resolve the initializer.
if let Some((init, els)) = local.kind.init_else_opt() {
Expand Down Expand Up @@ -3485,8 +3485,8 @@ impl<'a: 'ast, 'b, 'ast, 'tcx> LateResolutionVisitor<'a, 'b, 'ast, 'tcx> {
fn resolve_arm(&mut self, arm: &'ast Arm) {
self.with_rib(ValueNS, RibKind::Normal, |this| {
this.resolve_pattern_top(&arm.pat, PatternSource::Match);
walk_list!(this, visit_expr, &arm.guard);
walk_list!(this, visit_expr, &arm.body);
visit_opt!(this, visit_expr, &arm.guard);
visit_opt!(this, visit_expr, &arm.body);
});
}

Expand Down