Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Start removing rustc_middle::hir::map::Map #136466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 17, 2025
Merged

Start removing rustc_middle::hir::map::Map #136466

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7ff6790
Avoid unnecessary use of the `Map` trait.
nnethercote Feb 3, 2025
b51ab7d
Clarify `impl Map for !`.
nnethercote Feb 3, 2025
6021ba0
Rename `rustc_middle/src/hir/map/mod.rs` as `map.rs`.
nnethercote Feb 2, 2025
cd1d84c
Remove unused `Map::hir_node_by_def_id` method.
nnethercote Feb 2, 2025
f86f7ad
Move some `Map` methods onto `TyCtxt`.
nnethercote Feb 2, 2025
661f99b
Overhaul the `intravisit::Map` trait.
nnethercote Feb 3, 2025
f666361
Remove `TyCtxt::hir_krate`.
nnethercote Feb 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Clarify impl Map for !. 
All the methods are unreachable, so make that clearer.
  • Loading branch information
@nnethercote
nnethercote committed Feb 16, 2025
commit b51ab7d9be51ad70addf7ddb62dfa85e2bac1e2e
14 changes: 7 additions & 7 deletions compiler/rustc_hir/src/intravisit.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,25 +121,25 @@ pub trait Map<'hir> {
// Used when no map is actually available, forcing manual implementation of nested visitors.
impl<'hir> Map<'hir> for ! {
fn hir_node(&self, _: HirId) -> Node<'hir> {
*self;
unreachable!();
}
fn hir_node_by_def_id(&self, _: LocalDefId) -> Node<'hir> {
*self;
}
fn body(&self, _: BodyId) -> &'hir Body<'hir> {
*self;
unreachable!();
}
fn item(&self, _: ItemId) -> &'hir Item<'hir> {
*self;
unreachable!();
}
fn trait_item(&self, _: TraitItemId) -> &'hir TraitItem<'hir> {
*self;
unreachable!();
}
fn impl_item(&self, _: ImplItemId) -> &'hir ImplItem<'hir> {
*self;
unreachable!();
}
fn foreign_item(&self, _: ForeignItemId) -> &'hir ForeignItem<'hir> {
*self;
unreachable!();
}
}

Expand Down Expand Up @@ -203,7 +203,7 @@ use nested_filter::NestedFilter;
/// to monitor future changes to `Visitor` in case a new method with a
/// new default implementation gets introduced.)
pub trait Visitor<'v>: Sized {
// this type should not be overridden, it exists for convenient usage as `Self::Map`
// This type should not be overridden, it exists for convenient usage as `Self::Map`.
type Map: Map<'v> = <Self::NestedFilter as NestedFilter<'v>>::Map;

///////////////////////////////////////////////////////////////////////////
Expand Down