Thanks to visit codestin.com
Credit goes to github.com

Skip to content

compiler: give ExternAbi truly stable Hash and Ord #136901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 12, 2025
Merged

compiler: give ExternAbi truly stable Hash and Ord #136901

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d9c7abb
compiler: narrow scope of nightly cfg in rustc_abi
workingjubilee Feb 10, 2025
038c183
compiler: remove rustc_target reexport of rustc_abi::HashStableContext
workingjubilee Feb 10, 2025
8abff35
compiler: compare and hash ExternAbi like its string
workingjubilee Feb 10, 2025
edff4fe
compiler: remove AbiDatas
workingjubilee Feb 11, 2025
f8570e8
compiler: remove rustc_abi::lookup and AbiUnsupported
workingjubilee Feb 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
compiler: narrow scope of nightly cfg in rustc_abi
  • Loading branch information
@workingjubilee
workingjubilee committed Feb 12, 2025
commit d9c7abba55762f7ec25fc1d9a322f26896381e4f
3 changes: 2 additions & 1 deletion compiler/rustc_abi/src/extern_abi.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
use std::fmt;

#[cfg(feature = "nightly")]
use rustc_macros::{Decodable, Encodable, HashStable_Generic};

#[cfg(test)]
Expand All @@ -8,7 +9,7 @@ mod tests;
use ExternAbi as Abi;

#[derive(PartialEq, Eq, PartialOrd, Ord, Hash, Clone, Copy, Debug)]
#[derive(HashStable_Generic, Encodable, Decodable)]
#[cfg_attr(feature = "nightly", derive(HashStable_Generic, Encodable, Decodable))]
pub enum ExternAbi {
// Some of the ABIs come first because every time we add a new ABI, we have to re-bless all the
// hashing tests. These are used in many places, so giving them stable values reduces test
Expand Down
6 changes: 1 addition & 5 deletions compiler/rustc_abi/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,20 +52,16 @@ use bitflags::bitflags;
use rustc_data_structures::stable_hasher::StableOrd;
use rustc_index::{Idx, IndexSlice, IndexVec};
#[cfg(feature = "nightly")]
use rustc_macros::HashStable_Generic;
#[cfg(feature = "nightly")]
use rustc_macros::{Decodable_Generic, Encodable_Generic};
use rustc_macros::{Decodable_Generic, Encodable_Generic, HashStable_Generic};

mod callconv;
mod layout;
#[cfg(test)]
mod tests;

#[cfg(feature = "nightly")]
mod extern_abi;

pub use callconv::{Heterogeneous, HomogeneousAggregate, Reg, RegKind};
#[cfg(feature = "nightly")]
pub use extern_abi::{AbiDatas, AbiUnsupported, ExternAbi, all_names, lookup};
#[cfg(feature = "nightly")]
pub use layout::{FIRST_VARIANT, FieldIdx, Layout, TyAbiInterface, TyAndLayout, VariantIdx};
Expand Down