Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Mar 11, 2025

Since #137728 there is no sound way to create unsized tuples anymore. While we can't remove them from the language (tried here: #138093) due to people using PhantomData<(T, U)> where U: ?Sized (they'd have to use (PhantomData<T>, PhantomData<U>) now), we can remove the impls from libcore I believe.

r? libs I guess?

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 11, 2025
@oli-obk
Copy link
Contributor Author

oli-obk commented Mar 11, 2025

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 11, 2025
Remove some unsized tuple impls now that we don't support unsizing tuples anymore

Since rust-lang#137728 there is no sound way to create unsized tuples anymore. While we can't remove them from the language due to people using `PhantomData<(T, U)>` where `U: ?Sized` (they'd have to use `(PhantomData<T>, PhantomData<U>)` now), we can remove the impls from libcore I believe.

r? ghost
@bors
Copy link
Collaborator

bors commented Mar 11, 2025

⌛ Trying commit 93f64c5 with merge 0fe3684...

@bors
Copy link
Collaborator

bors commented Mar 11, 2025

☀️ Try build successful - checks-actions
Build commit: 0fe3684 (0fe3684930279e4d3be3aca66b30f82946ce9ac2)

@oli-obk
Copy link
Contributor Author

oli-obk commented Mar 11, 2025

@craterbot check

@craterbot
Copy link
Collaborator

👌 Experiment pr-138340 created and queued.
🤖 Automatically detected try build 0fe3684
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 11, 2025
@craterbot
Copy link
Collaborator

🚧 Experiment pr-138340 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🎉 Experiment pr-138340 is completed!
📊 27 regressed and 1 fixed (596183 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the denylist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Mar 12, 2025
@oli-obk
Copy link
Contributor Author

oli-obk commented Mar 12, 2025

The only regression is https://crates.io/crates/ord_subset/3.1.1 which was last updated 6 years ago. I'll check if I can contract the author, as there are a few crates depending on it

The author was unresponsive for a month, so moving ahead now.

@oli-obk oli-obk marked this pull request as ready for review April 17, 2025 14:19
@tgross35
Copy link
Contributor

Requesting libs-api since this will need FCP

r? libs-api

@rustbot rustbot added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Apr 17, 2025
@rustbot rustbot assigned m-ou-se and unassigned tgross35 Apr 17, 2025
@tgross35 tgross35 added needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. I-libs-api-nominated Nominated for discussion during a libs-api team meeting. and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 17, 2025
@joshtriplett
Copy link
Member

@rfcbot merge

@rfcbot
Copy link

rfcbot commented Apr 22, 2025

Team member @joshtriplett has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Apr 22, 2025
@rfcbot
Copy link

rfcbot commented Apr 22, 2025

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbot rfcbot removed the proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. label Apr 22, 2025
@Amanieu Amanieu removed the I-libs-api-nominated Nominated for discussion during a libs-api team meeting. label Apr 29, 2025
@rfcbot rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels May 2, 2025
@rfcbot
Copy link

rfcbot commented May 2, 2025

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

@rfcbot rfcbot added the to-announce Announce this issue on triage meeting label May 2, 2025
@oli-obk oli-obk removed the needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. label May 27, 2025
@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Jun 5, 2025
@oli-obk oli-obk force-pushed the one-size-fits-all branch from 93f64c5 to 36eb7d0 Compare July 2, 2025 13:55
@rust-log-analyzer

This comment has been minimized.

@oli-obk oli-obk force-pushed the one-size-fits-all branch from 36eb7d0 to 845d9ff Compare July 2, 2025 14:17
@m-ou-se
Copy link
Member

m-ou-se commented Jul 2, 2025

@bors r+

@bors
Copy link
Collaborator

bors commented Jul 2, 2025

📌 Commit 845d9ff has been approved by m-ou-se

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 2, 2025
bors added a commit that referenced this pull request Jul 2, 2025
Rollup of 11 pull requests

Successful merges:

 - #131923 (Derive `Copy` and `Hash` for `IntErrorKind`)
 - #138340 (Remove some unsized tuple impls now that we don't support unsizing tuples anymore)
 - #141219 (Change `{Box,Arc,Rc,Weak}::into_raw` to only work with `A = Global`)
 - #142212 (bootstrap: validate `rust.codegen-backends` & `target.<triple>.codegen-backends`)
 - #142237 (Detect more cases of unused_parens around types)
 - #142964 (Attribute rework: a parser for single attributes without arguments)
 - #143070 (Rewrite `macro_rules!` parser to not use the MBE engine itself)
 - #143235 (Assemble const bounds via normal item bounds in old solver too)
 - #143261 (Feed `explicit_predicates_of` instead of `predicates_of`)
 - #143276 (loop match: handle opaque patterns)
 - #143306 (Add `track_caller` attributes to trace origin of Clippy lints)

r? `@ghost`
`@rustbot` modify labels: rollup

try-job: aarch64-apple
try-job: x86_64-msvc-1
try-job: x86_64-gnu
try-job: dist-i586-gnu-i586-i686-musl
try-job: test-various
bors added a commit that referenced this pull request Jul 2, 2025
Rollup of 11 pull requests

Successful merges:

 - #131923 (Derive `Copy` and `Hash` for `IntErrorKind`)
 - #138340 (Remove some unsized tuple impls now that we don't support unsizing tuples anymore)
 - #141219 (Change `{Box,Arc,Rc,Weak}::into_raw` to only work with `A = Global`)
 - #142212 (bootstrap: validate `rust.codegen-backends` & `target.<triple>.codegen-backends`)
 - #142237 (Detect more cases of unused_parens around types)
 - #142964 (Attribute rework: a parser for single attributes without arguments)
 - #143070 (Rewrite `macro_rules!` parser to not use the MBE engine itself)
 - #143235 (Assemble const bounds via normal item bounds in old solver too)
 - #143261 (Feed `explicit_predicates_of` instead of `predicates_of`)
 - #143276 (loop match: handle opaque patterns)
 - #143306 (Add `track_caller` attributes to trace origin of Clippy lints)

r? `@ghost`
`@rustbot` modify labels: rollup

try-job: aarch64-apple
try-job: x86_64-msvc-1
try-job: x86_64-gnu
try-job: dist-i586-gnu-i586-i686-musl
try-job: test-various
@bors bors merged commit 7c9a03b into rust-lang:master Jul 3, 2025
10 checks passed
@rustbot rustbot added this to the 1.90.0 milestone Jul 3, 2025
rust-timer added a commit that referenced this pull request Jul 3, 2025
Rollup merge of #138340 - oli-obk:one-size-fits-all, r=m-ou-se

Remove some unsized tuple impls now that we don't support unsizing tuples anymore

Since #137728 there is no sound way to create unsized tuples anymore. While we can't remove them from the language (tried here: #138093) due to people using `PhantomData<(T, U)>` where `U: ?Sized` (they'd have to use `(PhantomData<T>, PhantomData<U>)` now), we can remove the impls from libcore I believe.

r? libs I guess?
github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request Jul 11, 2025
Remove some unsized tuple impls now that we don't support unsizing tuples anymore

Since rust-lang#137728 there is no sound way to create unsized tuples anymore. While we can't remove them from the language (tried here: rust-lang#138093) due to people using `PhantomData<(T, U)>` where `U: ?Sized` (they'd have to use `(PhantomData<T>, PhantomData<U>)` now), we can remove the impls from libcore I believe.

r? libs I guess?
github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request Jul 11, 2025
…iaskrgr

Rollup of 11 pull requests

Successful merges:

 - rust-lang#131923 (Derive `Copy` and `Hash` for `IntErrorKind`)
 - rust-lang#138340 (Remove some unsized tuple impls now that we don't support unsizing tuples anymore)
 - rust-lang#141219 (Change `{Box,Arc,Rc,Weak}::into_raw` to only work with `A = Global`)
 - rust-lang#142212 (bootstrap: validate `rust.codegen-backends` & `target.<triple>.codegen-backends`)
 - rust-lang#142237 (Detect more cases of unused_parens around types)
 - rust-lang#142964 (Attribute rework: a parser for single attributes without arguments)
 - rust-lang#143070 (Rewrite `macro_rules!` parser to not use the MBE engine itself)
 - rust-lang#143235 (Assemble const bounds via normal item bounds in old solver too)
 - rust-lang#143261 (Feed `explicit_predicates_of` instead of `predicates_of`)
 - rust-lang#143276 (loop match: handle opaque patterns)
 - rust-lang#143306 (Add `track_caller` attributes to trace origin of Clippy lints)

r? `@ghost`
`@rustbot` modify labels: rollup

try-job: aarch64-apple
try-job: x86_64-msvc-1
try-job: x86_64-gnu
try-job: dist-i586-gnu-i586-i686-musl
try-job: test-various
@BoxyUwU
Copy link
Member

BoxyUwU commented Aug 21, 2025

I am confused as to what happend here. #137728 does not represent a commitment to never having these impls, they were simply removed because it was inconvenient for derive(CoercePointee) as we do not have unstable trait impls. Why are we making a breaking change because something is temporarily not available.

I would expect that now that we have support for unstable trait impls (#144676) we could revert that PR, which would leave this breakage as being very confusingly motivated.

@BoxyUwU BoxyUwU added the I-libs-api-nominated Nominated for discussion during a libs-api team meeting. label Aug 21, 2025
wip-sync pushed a commit to NetBSD/pkgsrc-wip that referenced this pull request Sep 20, 2025
Pkgsrc changes:
 * Adjust patches to adapt to upstream changes and new versions.
 * assosicated checksums

Upstream changes relative to 1.89.0:

Version 1.90 (2025-09-18)
==========================

Language
--------
- [Split up the `unknown_or_malformed_diagnostic_attributes` lint]
  (rust-lang/rust#140717). This lint has
  been split up into four finer-grained lints, with
  `unknown_or_malformed_diagnostic_attributes` now being the lint
  group that contains these lints:
    1. `unknown_diagnostic_attributes`: unknown to the current compiler
    2. `misplaced_diagnostic_attributes`: placed on the wrong item
    3. `malformed_diagnostic_attributes`: malformed attribute syntax or options
    4. `malformed_diagnostic_format_literals`: malformed format string literal
- [Allow constants whose final value has references to mutable/external
  memory, but reject such constants as patterns]
  (rust-lang/rust#140942)
- [Allow volatile access to non-Rust memory, including address 0]
  (rust-lang/rust#141260)

Compiler
--------
- [Use `lld` by default on `x86_64-unknown-linux-gnu`]
  (rust-lang/rust#140525).
- [Tier 3 `musl` targets now link dynamically by default]
  (rust-lang/rust#144410). Affected targets:
    - `mips64-unknown-linux-muslabi64`
    - `powerpc64-unknown-linux-musl`
    - `powerpc-unknown-linux-musl`
    - `powerpc-unknown-linux-muslspe`
    - `riscv32gc-unknown-linux-musl`
    - `s390x-unknown-linux-musl`
    - `thumbv7neon-unknown-linux-musleabihf`

Platform Support
----------------
- [Demote `x86_64-apple-darwin` to Tier 2 with host tools]
  (rust-lang/rust#145252)

Refer to Rust's [platform support page][platform-support-doc]
for more information on Rust's tiered platform support.

[platform-support-doc]: https://doc.rust-lang.org/rustc/platform-support.html

Libraries
---------
- [Stabilize `u*::{checked,overflowing,saturating,wrapping}_sub_signed`]
  (rust-lang/rust#126043)
- [Allow comparisons between `CStr`, `CString`, and `Cow<CStr>`]
  (rust-lang/rust#137268)
- [Remove some unsized tuple impls since unsized tuples can't be constructed]
  (rust-lang/rust#138340)
- [Set `MSG_NOSIGNAL` for `UnixStream`]
  (rust-lang/rust#140005)
- [`proc_macro::Ident::new` now supports `$crate`.]
  (rust-lang/rust#141996)
- [Guarantee the pointer returned from `Thread::into_raw` has at
  least 8 bytes of alignment]
  (rust-lang/rust#143859)

Stabilized APIs
---------------
- [`u{n}::checked_sub_signed`]
  (https://doc.rust-lang.org/stable/std/primitive.usize.html#method.checked_sub_signed)
- [`u{n}::overflowing_sub_signed`]
  (https://doc.rust-lang.org/stable/std/primitive.usize.html#method.overflowing_sub_signed)
- [`u{n}::saturating_sub_signed`]
  (https://doc.rust-lang.org/stable/std/primitive.usize.html#method.saturating_sub_signed)
- [`u{n}::wrapping_sub_signed`]
  (https://doc.rust-lang.org/stable/std/primitive.usize.html#method.wrapping_sub_signed)
- [`impl Copy for IntErrorKind`]
  (https://doc.rust-lang.org/stable/std/num/enum.IntErrorKind.html#impl-Copy-for-IntErrorKind)
- [`impl Hash for IntErrorKind`]
  (https://doc.rust-lang.org/stable/std/num/enum.IntErrorKind.html#impl-Hash-for-IntErrorKind)
- [`impl PartialEq<&CStr> for CStr`]
  (https://doc.rust-lang.org/stable/std/ffi/struct.CStr.html#impl-PartialEq%3C%26CStr%3E-for-CStr)
- [`impl PartialEq<CString> for CStr`]
  (https://doc.rust-lang.org/stable/std/ffi/struct.CStr.html#impl-PartialEq%3CCString%3E-for-CStr)
- [`impl PartialEq<Cow<CStr>> for CStr`]
  (https://doc.rust-lang.org/stable/std/ffi/struct.CStr.html#impl-PartialEq%3CCow%3C'_,+CStr%3E%3E-for-CStr)
- [`impl PartialEq<&CStr> for CString`]
  (https://doc.rust-lang.org/stable/std/ffi/struct.CString.html#impl-PartialEq%3C%26CStr%3E-for-CString)
- [`impl PartialEq<CStr> for CString`]
  (https://doc.rust-lang.org/stable/std/ffi/struct.CString.html#impl-PartialEq%3CCStr%3E-for-CString)
- [`impl PartialEq<Cow<CStr>> for CString`]
  (https://doc.rust-lang.org/stable/std/ffi/struct.CString.html#impl-PartialEq%3CCow%3C'_,+CStr%3E%3E-for-CString)
- [`impl PartialEq<&CStr> for Cow<CStr>`]
  (https://doc.rust-lang.org/stable/std/borrow/enum.Cow.html#impl-PartialEq%3C%26CStr%3E-for-Cow%3C'_,+CStr%3E)
- [`impl PartialEq<CStr> for Cow<CStr>`]
  (https://doc.rust-lang.org/stable/std/borrow/enum.Cow.html#impl-PartialEq%3CCStr%3E-for-Cow%3C'_,+CStr%3E)
- [`impl PartialEq<CString> for Cow<CStr>`]
  (https://doc.rust-lang.org/stable/std/borrow/enum.Cow.html#impl-PartialEq%3CCString%3E-for-Cow%3C'_,+CStr%3E)

These previously stable APIs are now stable in const contexts:

- [`<[T]>::reverse`]
  (https://doc.rust-lang.org/stable/std/primitive.slice.html#method.reverse)
- [`f32::floor`]
  (https://doc.rust-lang.org/stable/std/primitive.f32.html#method.floor)
- [`f32::ceil`]
  (https://doc.rust-lang.org/stable/std/primitive.f32.html#method.ceil)
- [`f32::trunc`]
  (https://doc.rust-lang.org/stable/std/primitive.f32.html#method.trunc)
- [`f32::fract`]
  (https://doc.rust-lang.org/stable/std/primitive.f32.html#method.fract)
- [`f32::round`]
  (https://doc.rust-lang.org/stable/std/primitive.f32.html#method.round)
- [`f32::round_ties_even`]
  (https://doc.rust-lang.org/stable/std/primitive.f32.html#method.round_ties_even)
- [`f64::floor`]
  (https://doc.rust-lang.org/stable/std/primitive.f64.html#method.floor)
- [`f64::ceil`]
  (https://doc.rust-lang.org/stable/std/primitive.f64.html#method.ceil)
- [`f64::trunc`]
  (https://doc.rust-lang.org/stable/std/primitive.f64.html#method.trunc)
- [`f64::fract`]
  (https://doc.rust-lang.org/stable/std/primitive.f64.html#method.fract)
- [`f64::round`]
  (https://doc.rust-lang.org/stable/std/primitive.f64.html#method.round)
- [`f64::round_ties_even`]
  (https://doc.rust-lang.org/stable/std/primitive.f64.html#method.round_ties_even)

Cargo
-----
- [Add `http.proxy-cainfo` config for proxy certs]
  (rust-lang/cargo#15374)
- [Use `gix` for `cargo package`]
  (rust-lang/cargo#15534)
- [feat(publish): Stabilize multi-package publishing]
  (rust-lang/cargo#15636)

Rustdoc
-----
- [Add ways to collapse all impl blocks]
  (rust-lang/rust#141663). Previously the
  "Summary" button and "-" keyboard shortcut would never collapse
  `impl` blocks, now they do when shift is held
- [Display unsafe attributes with `unsafe()` wrappers]
  (rust-lang/rust#143662)

Compatibility Notes
-------------------
- [Use `lld` by default on `x86_64-unknown-linux-gnu`]
  (rust-lang/rust#140525).
  See also <https://blog.rust-lang.org/2025/09/01/rust-lld-on-1.90.0-stable/>.
- [Make `core::iter::Fuse`'s `Default` impl construct `I::default()`
  internally as promised in the docs instead of always being empty]
  (rust-lang/rust#140985)
- [Set `MSG_NOSIGNAL` for `UnixStream`]
  (rust-lang/rust#140005) This may change
  program behavior but results in the same behavior as other
  primitives (e.g., stdout, network sockets).  Programs relying on
  signals to terminate them should update handling of sockets to
  handle errors on write by exiting.
- [On Unix `std::env::home_dir` will use the fallback if the `HOME`
  environment variable is empty]
  (rust-lang/rust#141840)
- We now [reject unsupported `extern "{abi}"`s consistently in all
  positions] (rust-lang/rust#142134). This
  primarily affects the use of implementing traits on an `extern
  "{abi}"` function pointer, like `extern "stdcall" fn()`, on a
  platform that doesn't support that, like aarch64-unknown-linux-gnu.
  Direct usage of these unsupported ABI strings by declaring or
  defining functions was already rejected, so this is only a change
  for consistency.
- [const-eval: error when initializing a static writes to that static]
  (rust-lang/rust#143084)
- [Check that the `proc_macro_derive` macro has correct arguments
  when applied to the crate root]
  (rust-lang/rust#143607)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. I-libs-api-nominated Nominated for discussion during a libs-api team meeting. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.