print proc res for failed case in comp test #141977
Open
+12
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rustbot has assigned @Mark-Simulacrum. Use |
|
Some changes occurred in src/tools/compiletest cc @jieyouxu |
bjorn3
reviewed
Jun 3, 2025
|
Does GitHub have a bug in the rendering, or is there no diff in the current form of this PR? |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
|
@jieyouxu please, sorry. I had seen that my PR don't have changes. I need to set draft status. |
|
@rustbot ready |
This comment has been minimized.
This comment has been minimized.
|
@rustbot author |
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
@rustbot ready |
| self.props.error_patterns | ||
| ); | ||
|
|
||
| self.check_expected_errors(&proc_res); |
There was a problem hiding this comment.
Why should this be using the other proc_res?
|
☔ The latest upstream changes (presumably #143002) made this pull request unmergeable. Please resolve the merge conflicts. |
AMS21
added a commit
to AMS21/rust
that referenced
this pull request
Aug 15, 2025
When a UI test runs a compiled binary and an error/forbid pattern check fails, the failure message previously only showed compiler output, hiding the executed programs stdout/stderr. This makes it harder to see near-miss or unexpected runtime lines. Fixed rust-lang#141531 Supersedes rust-lang#141977
Kobzol
added a commit
to Kobzol/rust
that referenced
this pull request
Aug 15, 2025
Enhance UI test output handling for runtime errors When a UI test runs a compiled binary and an error/forbid pattern check fails, the failure message previously only showed compiler output, hiding the executed programs stdout/stderr. This makes it harder to see near-miss or unexpected runtime lines. Fixed rust-lang#141531 Supersedes rust-lang#141977
rust-timer
added a commit
that referenced
this pull request
Aug 15, 2025
Rollup merge of #145431 - AMS21:fix_141531, r=jieyouxu Enhance UI test output handling for runtime errors When a UI test runs a compiled binary and an error/forbid pattern check fails, the failure message previously only showed compiler output, hiding the executed programs stdout/stderr. This makes it harder to see near-miss or unexpected runtime lines. Fixed #141531 Supersedes #141977
|
@ilyaaay any updates on this? thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.