Thanks to visit codestin.com
Credit goes to github.com

Skip to content

compiler: Make c_int_width an integer #142352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 12, 2025
Merged

compiler: Make c_int_width an integer #142352

merged 2 commits into from
Jun 12, 2025

Conversation

workingjubilee
Copy link
Member

Because it is.

That's all I got.

@rustbot
Copy link
Collaborator

rustbot commented Jun 11, 2025

r? @wesleywiser

rustbot has assigned @wesleywiser.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 11, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jun 11, 2025

Some changes occurred in compiler/rustc_codegen_ssa

cc @WaffleLapkin

These commits modify compiler targets.
(See the Target Tier Policy.)

@wesleywiser
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 11, 2025

📌 Commit 87feee9 has been approved by wesleywiser

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 11, 2025
@matthiaskrgr matthiaskrgr mentioned this pull request Jun 12, 2025
Merged
bors added a commit that referenced this pull request Jun 12, 2025
@bors
Auto merge of #142392 - matthiaskrgr:rollup-9jrfqnu, r=matthiaskrgr
fe5c95d 
Rollup of 10 pull requests

Successful merges:

 - #141307 (Add method to retrieve body of closure in stable-mir)
 - #142040 (transmutability: shift abstraction boundary)
 - #142066 (More simple 2015 edition test decoupling)
 - #142157 (rustc_resolve: Improve `resolve_const_param_in_non_trivial_anon_const` wording)
 - #142217 (`tests/ui`: A New Order [10/N])
 - #142219 (`tests/ui`: A New Order [11/N])
 - #142261 (use correct edition when warning for unsafe attributes)
 - #142303 (Assorted bootstrap cleanups (step 1))
 - #142318 (Cleanup `rust-src` remapping and real dir)
 - #142352 (compiler: Make `c_int_width` an integer)

r? `@ghost`
`@rustbot` modify labels: rollup
@workingjubilee workingjubilee added the C-cleanup Category: PRs that clean code up or issues documenting cleanup. label Jun 12, 2025
@bors bors merged commit 2407761 into rust-lang:master Jun 12, 2025
10 checks passed
rust-timer added a commit that referenced this pull request Jun 12, 2025
@rust-timer
Unrolled build for #142352
875c6ea 
Rollup merge of #142352 - workingjubilee:c-int-width-is-an-integer, r=wesleywiser

compiler: Make `c_int_width` an integer

Because it is.

That's all I got.
@rustbot rustbot added this to the 1.89.0 milestone Jun 12, 2025
@workingjubilee workingjubilee deleted the c-int-width-is-an-integer branch June 12, 2025 19:20
@workingjubilee workingjubilee mentioned this pull request Jun 23, 2025
Closed
3 tasks
@workingjubilee workingjubilee mentioned this pull request Jul 18, 2025
Closed
RalfJung
RalfJung reviewed Jul 25, 2025
View reviewed changes
compiler/rustc_target/src/spec/json.rs
}

key!(c_int_width = "target-c-int-width");
key!(c_int_width = "target-c-int-width", u64 as u16);
Copy link
Member

@RalfJung RalfJung Jul 25, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks quite silly in the JSON now.^^

...

  "target-pointer-width": "64", // must be quoted
  "target-c-int-width": 32, // can't be quoted
...

@WaffleLapkin WaffleLapkin mentioned this pull request Jul 25, 2025
Merged
brainhoard-github pushed a commit to distro-core-curated-mirrors/poky-contrib that referenced this pull request Sep 19, 2025
@Yashinde145 @hsadinen
rust: Upgrade 1.89.0 -> 1.90.0
f4fb578 
https://blog.rust-lang.org/2025/09/18/Rust-1.90.0/

* Recent changes in rustc require 'target-c-int-width' to be an integer,
  not a string. This fixes type consistency when generating target specs.
  rust-lang/rust#142352.

* Rebase existing patches with v1.90.0.

* Drop merged patches with rust v1.90.0.
  - backport-fix-test-string-merging.patch

* The "remote-test-server" bin is now generated in stage1-tools-bin dir
  rather than stage2. Update the test suite accordingly.

Signed-off-by: Yash Shinde <[email protected]>
Signed-off-by: Harish Sadineni <[email protected]>
brainhoard-github pushed a commit to distro-core-curated-mirrors/poky-contrib that referenced this pull request Sep 22, 2025
@Yashinde145 @hsadinen
rust: Upgrade 1.89.0 -> 1.90.0
247bbce 
https://blog.rust-lang.org/2025/09/18/Rust-1.90.0/

* Recent changes in rustc require 'target-c-int-width' to be an integer,
  not a string. This fixes type consistency when generating target specs.
  rust-lang/rust#142352.

* Rebase existing patches with v1.90.0.

* Drop merged patches with rust v1.90.0.
  - backport-fix-test-string-merging.patch

* The "remote-test-server" bin is now generated in stage1-tools-bin dir
  rather than stage2. Update the test suite accordingly.

  The tests/{assembly/codegen} dirs are renamed to
  tests/{assembly,codegen}-llvm. Update the test suite and
  patches accordingly.
  https://github.com/rust-lang/rust/pull/144249/commits

* 5 newly added codegen-llvm tests fail only on riscv64.
  Enable them on arm32/64 and x86-32/64 targets, while restricting
  them on riscv64 via `only-<target_arch>` tags.

Signed-off-by: Yash Shinde <[email protected]>
Signed-off-by: Harish Sadineni <[email protected]>
brainhoard-github pushed a commit to distro-core-curated-mirrors/poky-contrib that referenced this pull request Sep 23, 2025
@Yashinde145 @hsadinen
rust: Upgrade 1.89.0 -> 1.90.0
4387115 
https://blog.rust-lang.org/2025/09/18/Rust-1.90.0/

* Recent changes in rustc require 'target-c-int-width' to be an integer,
  not a string. This fixes type consistency when generating target specs.
  rust-lang/rust#142352.

* Rebase existing patches with v1.90.0.

* Drop merged patches with rust v1.90.0.
  - backport-fix-test-string-merging.patch

* The "remote-test-server" bin is now generated in stage1-tools-bin dir
  rather than stage2. Update the test suite accordingly.

  The tests/{assembly/codegen} dirs are renamed to
  tests/{assembly,codegen}-llvm. Update the test suite and
  patches accordingly.
  https://github.com/rust-lang/rust/pull/144249/commits

* Use "//@ ignore-riscv64" tag for tests failing on riscv-64 instead of previous
  "only-<target_arch>" tags.

Signed-off-by: Yash Shinde <[email protected]>
Signed-off-by: Harish Sadineni <[email protected]>
brainhoard-github pushed a commit to distro-core-curated-mirrors/poky-contrib that referenced this pull request Sep 24, 2025
@Yashinde145 @hsadinen
rust: Upgrade 1.89.0 -> 1.90.0
2785a05 
https://blog.rust-lang.org/2025/09/18/Rust-1.90.0/

* Recent changes in rustc require 'target-c-int-width' to be an integer,
  not a string. This fixes type consistency when generating target specs.
  rust-lang/rust#142352.

* Rebase existing patches with v1.90.0.

* Drop merged patches with rust v1.90.0.
  - backport-fix-test-string-merging.patch
  rust-lang/rust@2d51acd

* The "remote-test-server" bin is now generated in stage1-tools-bin dir
  rather than stage2. Update the test suite accordingly.

  The tests/{assembly/codegen} dirs are renamed to
  tests/{assembly,codegen}-llvm. Update the test suite and
  patches accordingly.
  https://github.com/rust-lang/rust/pull/144249/commits

* Use "//@ ignore-riscv64" tag for tests failing on riscv-64 instead of previous
  "only-<target_arch>" tags.

  Test results summary:

   rust v1.90.0
   +-----------+--------+---------+
   | Machine   | Passed | Ignored |
   +-----------+--------+---------+
   | arm-32    | 29,517 |  1,529  |
   | arm-64    | 29,608 |  1,471  |
   | x86-32    | 29,508 |  1,507  |
   | x86-64    | 29,903 |  1,275  |
   | riscv-64  | 29,584 |  1,494  |
   +-----------+--------+---------+

   Test results difference (1.90 - 1.89):
   +-----------+--------+---------+
   | Machine   | Passed | Ignored |
   +-----------+--------+---------+
   | arm-32    | + 278  |   +61   |
   | arm-64    | + 279  |   +59   |
   | x86-32    | + 277  |   +58   |
   | x86-64    | + 419  |   +50   |
   | riscv-64  | + 280  |   +58   |
   +-----------+--------+---------+

Signed-off-by: Yash Shinde <[email protected]>
Signed-off-by: Harish Sadineni <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RalfJung RalfJung RalfJung left review comments

@wesleywiser wesleywiser wesleywiser approved these changes

Assignees

@wesleywiser wesleywiser

Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.89.0
Development

Successfully merging this pull request may close these issues.
5 participants
@workingjubilee @rustbot @wesleywiser @bors @RalfJung