Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Leave from CopyProp early when there are no replacements #142870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 25, 2025
Merged

Leave from CopyProp early when there are no replacements #142870

merged 1 commit into from
Jun 25, 2025
+10 −8

Conversation

tmiasko
Copy link
Contributor

@tmiasko tmiasko commented Jun 22, 2025

r? cjgillot

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 22, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jun 22, 2025

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

@cjgillot

This comment was marked as off-topic.

Sign in to view
@cjgillot
Copy link
Contributor

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 22, 2025
bors added a commit that referenced this pull request Jun 22, 2025
@bors
Auto merge of #142870 - tmiasko:copy-prop-early-exit, r=<try>
fb8fc2c 
Leave from CopyProp early when there are no replacements

r? cjgillot
@bors
Copy link
Collaborator

bors commented Jun 22, 2025

⌛ Trying commit c353539 with merge fb8fc2c...

@bors
Copy link
Collaborator

bors commented Jun 22, 2025

☀️ Try build successful - checks-actions
Build commit: fb8fc2c (fb8fc2c158d909df693abe433f3aa7da3b68db9e)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (fb8fc2c): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (secondary -2.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -2.1% [-3.2%, -1.6%] 3
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 689.082s -> 689.371s (0.04%)
Artifact size: 371.89 MiB -> 371.87 MiB (-0.01%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 22, 2025
@cjgillot
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 22, 2025

📌 Commit c353539 has been approved by cjgillot

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 22, 2025
@workingjubilee
Copy link
Member

forcing rollup=never drain:

@bors p=5

@bors
Copy link
Collaborator

bors commented Jun 25, 2025

⌛ Testing commit c353539 with merge 8cf5fad...

@bors
Copy link
Collaborator

bors commented Jun 25, 2025

☀️ Test successful - checks-actions
Approved by: cjgillot
Pushing 8cf5fad to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 25, 2025
@bors bors merged commit 8cf5fad into rust-lang:master Jun 25, 2025
11 checks passed
@rustbot rustbot added this to the 1.90.0 milestone Jun 25, 2025
@tmiasko tmiasko deleted the copy-prop-early-exit branch June 25, 2025 17:33
@github-actions GitHub Actions
Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 2801f9a (parent) -> 8cf5fad (this PR)

Test differences

No test diffs found

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 8cf5fad73d4e8f41863ecc3bcfa114eabc951faa --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-apple-various: 7019.9s -> 8577.7s (22.2%)
  2. x86_64-apple-2: 5407.0s -> 4321.1s (-20.1%)
  3. mingw-check-1: 1890.1s -> 1576.1s (-16.6%)
  4. dist-x86_64-msvc-alt: 9868.4s -> 8431.0s (-14.6%)
  5. i686-gnu-2: 6496.5s -> 5569.9s (-14.3%)
  6. i686-gnu-1: 8181.8s -> 7327.1s (-10.4%)
  7. x86_64-gnu-tools: 3731.6s -> 3343.3s (-10.4%)
  8. x86_64-gnu-llvm-19-1: 3676.4s -> 3317.2s (-9.8%)
  9. x86_64-rust-for-linux: 2959.9s -> 2673.8s (-9.7%)
  10. x86_64-apple-1: 7431.8s -> 6787.1s (-8.7%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

This was referenced Jun 25, 2025
Open
Open
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (8cf5fad): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 0.3% [0.3%, 0.3%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (primary 7.3%, secondary 2.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 7.3% [7.3%, 7.3%] 1
Regressions ❌
(secondary)		 2.7% [2.7%, 2.7%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 7.3% [7.3%, 7.3%] 1

Cycles

Results (secondary 0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 2.3% [2.3%, 2.3%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -2.2% [-2.2%, -2.2%] 1
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 690.11s -> 688.412s (-0.25%)
Artifact size: 372.15 MiB -> 372.01 MiB (-0.04%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cjgillot cjgillot

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.90.0
Development

Successfully merging this pull request may close these issues.
6 participants
@tmiasko @rustbot @cjgillot @rust-timer @bors @workingjubilee