Make named asm_labels lint not trigger on hexagon register spans #143037

androm3da · 2025-06-26T02:45:15Z

rustbot · 2025-06-26T02:45:20Z

rustbot has assigned @SparrowLii.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Fixes rust-lang#143021

rust-log-analyzer · 2025-06-26T04:03:05Z

The job aarch64-gnu-llvm-19-1 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

normalized stderr:
error: avoid using named labels in inline assembly
##[error]  --> $DIR/hexagon-register-pairs.rs:18:15
   |
LL |         asm!("r1:0 = memd(r29+#0)", lateout("r0") _, lateout("r1") _);
   |               ^^
   |
   = help: only local labels of the form `<number>:` should be used in inline asm
   = note: see the asm section of Rust By Example <https://doc.rust-lang.org/nightly/rust-by-example/unsafe/asm.html#labels> for more information
   = note: `#[deny(named_asm_labels)]` on by default

error: avoid using named labels in inline assembly
##[error]  --> $DIR/hexagon-register-pairs.rs:19:15
   |
LL |         asm!("r3:2 = combine(#1, #0)", lateout("r2") _, lateout("r3") _);
   |               ^^
   |
   = help: only local labels of the form `<number>:` should be used in inline asm
   = note: see the asm section of Rust By Example <https://doc.rust-lang.org/nightly/rust-by-example/unsafe/asm.html#labels> for more information

error: avoid using named labels in inline assembly
##[error]  --> $DIR/hexagon-register-pairs.rs:20:15
   |
LL |         asm!("r15:14 = memd(r30+#8)", lateout("r14") _, lateout("r15") _);
   |               ^^^
   |
   = help: only local labels of the form `<number>:` should be used in inline asm
   = note: see the asm section of Rust By Example <https://doc.rust-lang.org/nightly/rust-by-example/unsafe/asm.html#labels> for more information

error: avoid using named labels in inline assembly
##[error]  --> $DIR/hexagon-register-pairs.rs:31:15
   |
LL |         asm!("label1: r7:6 = combine(#2, #3)");
   |               ^^^^^^
   |
   = help: only local labels of the form `<number>:` should be used in inline asm
   = note: see the asm section of Rust By Example <https://doc.rust-lang.org/nightly/rust-by-example/unsafe/asm.html#labels> for more information

error: avoid using named labels in inline assembly
##[error]  --> $DIR/hexagon-register-pairs.rs:31:23
   |
LL |         asm!("label1: r7:6 = combine(#2, #3)");
   |                       ^^
   |
   = help: only local labels of the form `<number>:` should be used in inline asm
   = note: see the asm section of Rust By Example <https://doc.rust-lang.org/nightly/rust-by-example/unsafe/asm.html#labels> for more information

error: avoid using named labels in inline assembly
##[error]  --> $DIR/hexagon-register-pairs.rs:34:15
   |
LL |         asm!("hexagon_label: nop");
   |               ^^^^^^^^^^^^^
   |
   = help: only local labels of the form `<number>:` should be used in inline asm
   = note: see the asm section of Rust By Example <https://doc.rust-lang.org/nightly/rust-by-example/unsafe/asm.html#labels> for more information

error: aborting due to 6 previous errors




The actual stderr differed from the expected stderr
To update references, rerun the tests and pass the `--bless` flag
To only update this specific test, also pass `--test-args asm/hexagon-register-pairs.rs`

error: 1 errors occurred comparing output.
status: exit status: 1
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="short" "/checkout/obj/build/aarch64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/ui/asm/hexagon-register-pairs.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/aarch64-unknown-linux-gnu/stage2" "--check-cfg" "cfg(test,FALSE)" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/aarch64-unknown-linux-gnu/test/ui/asm/hexagon-register-pairs" "-A" "unused" "-A" "internal_features" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/aarch64-unknown-linux-gnu/native/rust-test-helpers" "--target" "hexagon-unknown-linux-musl" "-Cpanic=abort" "-Cforce-unwind-tables=yes" "--extern" "minicore=/checkout/obj/build/aarch64-unknown-linux-gnu/test/ui/asm/hexagon-register-pairs/libminicore.rlib"
stdout: none
--- stderr -------------------------------
error: avoid using named labels in inline assembly
##[error]  --> /checkout/tests/ui/asm/hexagon-register-pairs.rs:18:15
   |
LL |         asm!("r1:0 = memd(r29+#0)", lateout("r0") _, lateout("r1") _);
   |               ^^
   |
   = help: only local labels of the form `<number>:` should be used in inline asm
   = note: see the asm section of Rust By Example <https://doc.rust-lang.org/nightly/rust-by-example/unsafe/asm.html#labels> for more information
   = note: `#[deny(named_asm_labels)]` on by default

error: avoid using named labels in inline assembly
##[error]  --> /checkout/tests/ui/asm/hexagon-register-pairs.rs:19:15
   |
LL |         asm!("r3:2 = combine(#1, #0)", lateout("r2") _, lateout("r3") _);
   |               ^^
   |
   = help: only local labels of the form `<number>:` should be used in inline asm
   = note: see the asm section of Rust By Example <https://doc.rust-lang.org/nightly/rust-by-example/unsafe/asm.html#labels> for more information

error: avoid using named labels in inline assembly
##[error]  --> /checkout/tests/ui/asm/hexagon-register-pairs.rs:20:15
   |
LL |         asm!("r15:14 = memd(r30+#8)", lateout("r14") _, lateout("r15") _);
   |               ^^^
   |
   = help: only local labels of the form `<number>:` should be used in inline asm
   = note: see the asm section of Rust By Example <https://doc.rust-lang.org/nightly/rust-by-example/unsafe/asm.html#labels> for more information

error: avoid using named labels in inline assembly
##[error]  --> /checkout/tests/ui/asm/hexagon-register-pairs.rs:31:15
   |
LL |         asm!("label1: r7:6 = combine(#2, #3)"); //~ ERROR avoid using named labels
   |               ^^^^^^
   |
   = help: only local labels of the form `<number>:` should be used in inline asm
   = note: see the asm section of Rust By Example <https://doc.rust-lang.org/nightly/rust-by-example/unsafe/asm.html#labels> for more information

error: avoid using named labels in inline assembly
##[error]  --> /checkout/tests/ui/asm/hexagon-register-pairs.rs:31:23
   |
LL |         asm!("label1: r7:6 = combine(#2, #3)"); //~ ERROR avoid using named labels
   |                       ^^
   |
   = help: only local labels of the form `<number>:` should be used in inline asm
   = note: see the asm section of Rust By Example <https://doc.rust-lang.org/nightly/rust-by-example/unsafe/asm.html#labels> for more information

error: avoid using named labels in inline assembly
##[error]  --> /checkout/tests/ui/asm/hexagon-register-pairs.rs:34:15
   |
LL |         asm!("hexagon_label: nop"); //~ ERROR avoid using named labels
   |               ^^^^^^^^^^^^^
   |
   = help: only local labels of the form `<number>:` should be used in inline asm
   = note: see the asm section of Rust By Example <https://doc.rust-lang.org/nightly/rust-by-example/unsafe/asm.html#labels> for more information

error: aborting due to 6 previous errors
------------------------------------------

SparrowLii · 2025-07-01T10:02:26Z

r? @workingjubilee since this relates with asm :)

rustbot · 2025-07-01T10:02:30Z

workingjubilee is currently at their maximum review capacity.
They may take a while to respond.

workingjubilee · 2025-07-04T23:10:46Z

mmmh

r? @Amanieu

androm3da · 2025-07-07T04:34:32Z

r? @Amanieu

Maybe I should mark this PR as a draft while I work on llvm/llvm-project#146215 as a step towards a long-term solution.

Amanieu · 2025-07-08T23:09:16Z

Sure, though you will need to pick another reviewer on the LLVM side since I no longer have review rights in LLVM.

wesleywiser · 2025-09-25T14:48:04Z

@androm3da is the plan to merge this into rustc and then eventually switch to using llvm/llvm-project#146215 in the future? If so, I guess this still needs to be reviewed?

androm3da · 2025-09-26T13:25:25Z

@androm3da is the plan to merge this into rustc and then eventually switch to using llvm/llvm-project#146215 in the future? If so, I guess this still needs to be reviewed?

Yeah, maybe that makes the most sense. I was optimistic about making the assembler change but I just haven't gotten to spend time on it. If @Amanieu or someone else is able to review this PR that would be great. I'll still follow through on the assembler change though.

rustbot assigned SparrowLii Jun 26, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 26, 2025

This comment has been minimized.

Sign in to view

androm3da force-pushed the bcain/hexagon_regspan_label branch from 1a4538b to 18a091e Compare June 26, 2025 02:56

This comment has been minimized.

Sign in to view

Make named asm_labels lint not trigger on hexagon register spans

dea531e

Fixes rust-lang#143021

androm3da force-pushed the bcain/hexagon_regspan_label branch from 18a091e to dea531e Compare June 26, 2025 03:17

rustbot assigned workingjubilee and unassigned SparrowLii Jul 1, 2025

rustbot assigned Amanieu and unassigned workingjubilee Jul 4, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Make named asm_labels lint not trigger on hexagon register spans #143037

Make named asm_labels lint not trigger on hexagon register spans #143037

androm3da commented Jun 26, 2025

Uh oh!

rustbot commented Jun 26, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-log-analyzer commented Jun 26, 2025

Uh oh!

SparrowLii commented Jul 1, 2025

Uh oh!

rustbot commented Jul 1, 2025

Uh oh!

workingjubilee commented Jul 4, 2025

Uh oh!

androm3da commented Jul 7, 2025

Uh oh!

Amanieu commented Jul 8, 2025

Uh oh!

wesleywiser commented Sep 25, 2025

Uh oh!

androm3da commented Sep 26, 2025

Uh oh!

Uh oh!

Make named asm_labels lint not trigger on hexagon register spans #143037

Are you sure you want to change the base?

Make named asm_labels lint not trigger on hexagon register spans #143037

Conversation

androm3da commented Jun 26, 2025

Uh oh!

rustbot commented Jun 26, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-log-analyzer commented Jun 26, 2025

Uh oh!

SparrowLii commented Jul 1, 2025

Uh oh!

rustbot commented Jul 1, 2025

Uh oh!

workingjubilee commented Jul 4, 2025

Uh oh!

androm3da commented Jul 7, 2025

Uh oh!

Amanieu commented Jul 8, 2025

Uh oh!

wesleywiser commented Sep 25, 2025

Uh oh!

androm3da commented Sep 26, 2025

Uh oh!

Uh oh!