Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

RalfJung
Copy link
Member

Fixes #142404 by also calling the relevant hook for writes, not just reads. To avoid erroring during the actual write of the initial value, we neuter the hook when popping the final stack frame.

Calling the hook during writes requires changing its signature since we cannot pass in the entire interpreter any more.

While doing this I also realized a gap in #142575 for zero-sized copies on the read side, so I fixed that and added a test.

r? @oli-obk

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 27, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jun 27, 2025

Some changes occurred to the CTFE / Miri interpreter

cc @rust-lang/miri

Some changes occurred to the CTFE machinery

cc @RalfJung, @oli-obk, @lcnr

.provenance()
.prepare_copy(src_range, dest_offset, num_copies, self)
.map_err(|e| e.to_interp_error(dest_alloc_id))?;
.map_err(|e| e.to_interp_error(src_alloc_id))?;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is another drive-by fix, I don't think it makes any sense to use the dest_alloc_id here -- the operation was invoked on the src_alloc, after all.

@RalfJung RalfJung force-pushed the const-eval-recursive-static-write branch from 98b111e to ed4f01e Compare June 27, 2025 12:39
@oli-obk
Copy link
Contributor

oli-obk commented Jun 27, 2025

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 27, 2025

📌 Commit ed4f01e has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 27, 2025
bors added a commit that referenced this pull request Jun 27, 2025
Rollup of 10 pull requests

Successful merges:

 - #142270 (Rustdoc js: even more typechecking improvements)
 - #142420 (Report infer ty errors during hir ty lowering)
 - #142671 (add #![rustc_no_implicit_bounds])
 - #142721 (Add tracing to `InterpCx::layout_of()` )
 - #142818 (Port `#[used]` to new attribute parsing infrastructure)
 - #143020 (codegen_fn_attrs: make comment more precise)
 - #143051 (Add tracing to `validate_operand`)
 - #143060 (Only args in main diag are saved and restored without removing the newly added ones)
 - #143065 (Improve recovery when users write `where:`)
 - #143084 (const-eval: error when initializing a static writes to that static)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 0bbeeff into rust-lang:master Jun 27, 2025
10 checks passed
rust-timer added a commit that referenced this pull request Jun 27, 2025
Rollup merge of #143084 - RalfJung:const-eval-recursive-static-write, r=oli-obk

const-eval: error when initializing a static writes to that static

Fixes #142404 by also calling the relevant hook for writes, not just reads. To avoid erroring during the actual write of the initial value, we neuter the hook when popping the final stack frame.

Calling the hook during writes requires changing its signature since we cannot pass in the entire interpreter any more.

While doing this I also realized a gap in #142575 for zero-sized copies on the read side, so I fixed that and added a test.

r? `@oli-obk`
@rustbot rustbot added this to the 1.90.0 milestone Jun 27, 2025
@RalfJung RalfJung deleted the const-eval-recursive-static-write branch June 27, 2025 20:32
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Jun 28, 2025
Rollup of 10 pull requests

Successful merges:

 - rust-lang/rust#142270 (Rustdoc js: even more typechecking improvements)
 - rust-lang/rust#142420 (Report infer ty errors during hir ty lowering)
 - rust-lang/rust#142671 (add #![rustc_no_implicit_bounds])
 - rust-lang/rust#142721 (Add tracing to `InterpCx::layout_of()` )
 - rust-lang/rust#142818 (Port `#[used]` to new attribute parsing infrastructure)
 - rust-lang/rust#143020 (codegen_fn_attrs: make comment more precise)
 - rust-lang/rust#143051 (Add tracing to `validate_operand`)
 - rust-lang/rust#143060 (Only args in main diag are saved and restored without removing the newly added ones)
 - rust-lang/rust#143065 (Improve recovery when users write `where:`)
 - rust-lang/rust#143084 (const-eval: error when initializing a static writes to that static)

r? `@ghost`
`@rustbot` modify labels: rollup
@traviscross
Copy link
Contributor

traviscross commented Jul 4, 2025

@rustbot labels +T-lang +relnotes

This is a breaking change, though I hope and expect it won't affect too much code. Still, we should probably flag this in the compatibility section of the release notes.

Probably, as a process matter, we should have lang FCPed this (it would have been an easy call -- it's clearly a bug fix). I don't feel strongly about perturbing anything here, though, (and I appreciate this having been fixed) so let's just...

cc @rust-lang/lang

Looking at it, the Reference is already correct. It says:

Writes to static items are not allowed in any constant evaluation context.

Can't be any more clear than that.

cc @ehuss

@rustbot rustbot added relnotes Marks issues that should be documented in the release notes of the next release. T-lang Relevant to the language team labels Jul 4, 2025
@traviscross traviscross removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jul 4, 2025
@RalfJung
Copy link
Member Author

RalfJung commented Jul 5, 2025

Ah fair, I thought of this as more of a bugfix but I should have gotten confirmation for that.

wip-sync pushed a commit to NetBSD/pkgsrc-wip that referenced this pull request Sep 20, 2025
Pkgsrc changes:
 * Adjust patches to adapt to upstream changes and new versions.
 * assosicated checksums

Upstream changes relative to 1.89.0:

Version 1.90 (2025-09-18)
==========================

Language
--------
- [Split up the `unknown_or_malformed_diagnostic_attributes` lint]
  (rust-lang/rust#140717). This lint has
  been split up into four finer-grained lints, with
  `unknown_or_malformed_diagnostic_attributes` now being the lint
  group that contains these lints:
    1. `unknown_diagnostic_attributes`: unknown to the current compiler
    2. `misplaced_diagnostic_attributes`: placed on the wrong item
    3. `malformed_diagnostic_attributes`: malformed attribute syntax or options
    4. `malformed_diagnostic_format_literals`: malformed format string literal
- [Allow constants whose final value has references to mutable/external
  memory, but reject such constants as patterns]
  (rust-lang/rust#140942)
- [Allow volatile access to non-Rust memory, including address 0]
  (rust-lang/rust#141260)

Compiler
--------
- [Use `lld` by default on `x86_64-unknown-linux-gnu`]
  (rust-lang/rust#140525).
- [Tier 3 `musl` targets now link dynamically by default]
  (rust-lang/rust#144410). Affected targets:
    - `mips64-unknown-linux-muslabi64`
    - `powerpc64-unknown-linux-musl`
    - `powerpc-unknown-linux-musl`
    - `powerpc-unknown-linux-muslspe`
    - `riscv32gc-unknown-linux-musl`
    - `s390x-unknown-linux-musl`
    - `thumbv7neon-unknown-linux-musleabihf`

Platform Support
----------------
- [Demote `x86_64-apple-darwin` to Tier 2 with host tools]
  (rust-lang/rust#145252)

Refer to Rust's [platform support page][platform-support-doc]
for more information on Rust's tiered platform support.

[platform-support-doc]: https://doc.rust-lang.org/rustc/platform-support.html

Libraries
---------
- [Stabilize `u*::{checked,overflowing,saturating,wrapping}_sub_signed`]
  (rust-lang/rust#126043)
- [Allow comparisons between `CStr`, `CString`, and `Cow<CStr>`]
  (rust-lang/rust#137268)
- [Remove some unsized tuple impls since unsized tuples can't be constructed]
  (rust-lang/rust#138340)
- [Set `MSG_NOSIGNAL` for `UnixStream`]
  (rust-lang/rust#140005)
- [`proc_macro::Ident::new` now supports `$crate`.]
  (rust-lang/rust#141996)
- [Guarantee the pointer returned from `Thread::into_raw` has at
  least 8 bytes of alignment]
  (rust-lang/rust#143859)

Stabilized APIs
---------------
- [`u{n}::checked_sub_signed`]
  (https://doc.rust-lang.org/stable/std/primitive.usize.html#method.checked_sub_signed)
- [`u{n}::overflowing_sub_signed`]
  (https://doc.rust-lang.org/stable/std/primitive.usize.html#method.overflowing_sub_signed)
- [`u{n}::saturating_sub_signed`]
  (https://doc.rust-lang.org/stable/std/primitive.usize.html#method.saturating_sub_signed)
- [`u{n}::wrapping_sub_signed`]
  (https://doc.rust-lang.org/stable/std/primitive.usize.html#method.wrapping_sub_signed)
- [`impl Copy for IntErrorKind`]
  (https://doc.rust-lang.org/stable/std/num/enum.IntErrorKind.html#impl-Copy-for-IntErrorKind)
- [`impl Hash for IntErrorKind`]
  (https://doc.rust-lang.org/stable/std/num/enum.IntErrorKind.html#impl-Hash-for-IntErrorKind)
- [`impl PartialEq<&CStr> for CStr`]
  (https://doc.rust-lang.org/stable/std/ffi/struct.CStr.html#impl-PartialEq%3C%26CStr%3E-for-CStr)
- [`impl PartialEq<CString> for CStr`]
  (https://doc.rust-lang.org/stable/std/ffi/struct.CStr.html#impl-PartialEq%3CCString%3E-for-CStr)
- [`impl PartialEq<Cow<CStr>> for CStr`]
  (https://doc.rust-lang.org/stable/std/ffi/struct.CStr.html#impl-PartialEq%3CCow%3C'_,+CStr%3E%3E-for-CStr)
- [`impl PartialEq<&CStr> for CString`]
  (https://doc.rust-lang.org/stable/std/ffi/struct.CString.html#impl-PartialEq%3C%26CStr%3E-for-CString)
- [`impl PartialEq<CStr> for CString`]
  (https://doc.rust-lang.org/stable/std/ffi/struct.CString.html#impl-PartialEq%3CCStr%3E-for-CString)
- [`impl PartialEq<Cow<CStr>> for CString`]
  (https://doc.rust-lang.org/stable/std/ffi/struct.CString.html#impl-PartialEq%3CCow%3C'_,+CStr%3E%3E-for-CString)
- [`impl PartialEq<&CStr> for Cow<CStr>`]
  (https://doc.rust-lang.org/stable/std/borrow/enum.Cow.html#impl-PartialEq%3C%26CStr%3E-for-Cow%3C'_,+CStr%3E)
- [`impl PartialEq<CStr> for Cow<CStr>`]
  (https://doc.rust-lang.org/stable/std/borrow/enum.Cow.html#impl-PartialEq%3CCStr%3E-for-Cow%3C'_,+CStr%3E)
- [`impl PartialEq<CString> for Cow<CStr>`]
  (https://doc.rust-lang.org/stable/std/borrow/enum.Cow.html#impl-PartialEq%3CCString%3E-for-Cow%3C'_,+CStr%3E)

These previously stable APIs are now stable in const contexts:

- [`<[T]>::reverse`]
  (https://doc.rust-lang.org/stable/std/primitive.slice.html#method.reverse)
- [`f32::floor`]
  (https://doc.rust-lang.org/stable/std/primitive.f32.html#method.floor)
- [`f32::ceil`]
  (https://doc.rust-lang.org/stable/std/primitive.f32.html#method.ceil)
- [`f32::trunc`]
  (https://doc.rust-lang.org/stable/std/primitive.f32.html#method.trunc)
- [`f32::fract`]
  (https://doc.rust-lang.org/stable/std/primitive.f32.html#method.fract)
- [`f32::round`]
  (https://doc.rust-lang.org/stable/std/primitive.f32.html#method.round)
- [`f32::round_ties_even`]
  (https://doc.rust-lang.org/stable/std/primitive.f32.html#method.round_ties_even)
- [`f64::floor`]
  (https://doc.rust-lang.org/stable/std/primitive.f64.html#method.floor)
- [`f64::ceil`]
  (https://doc.rust-lang.org/stable/std/primitive.f64.html#method.ceil)
- [`f64::trunc`]
  (https://doc.rust-lang.org/stable/std/primitive.f64.html#method.trunc)
- [`f64::fract`]
  (https://doc.rust-lang.org/stable/std/primitive.f64.html#method.fract)
- [`f64::round`]
  (https://doc.rust-lang.org/stable/std/primitive.f64.html#method.round)
- [`f64::round_ties_even`]
  (https://doc.rust-lang.org/stable/std/primitive.f64.html#method.round_ties_even)

Cargo
-----
- [Add `http.proxy-cainfo` config for proxy certs]
  (rust-lang/cargo#15374)
- [Use `gix` for `cargo package`]
  (rust-lang/cargo#15534)
- [feat(publish): Stabilize multi-package publishing]
  (rust-lang/cargo#15636)

Rustdoc
-----
- [Add ways to collapse all impl blocks]
  (rust-lang/rust#141663). Previously the
  "Summary" button and "-" keyboard shortcut would never collapse
  `impl` blocks, now they do when shift is held
- [Display unsafe attributes with `unsafe()` wrappers]
  (rust-lang/rust#143662)

Compatibility Notes
-------------------
- [Use `lld` by default on `x86_64-unknown-linux-gnu`]
  (rust-lang/rust#140525).
  See also <https://blog.rust-lang.org/2025/09/01/rust-lld-on-1.90.0-stable/>.
- [Make `core::iter::Fuse`'s `Default` impl construct `I::default()`
  internally as promised in the docs instead of always being empty]
  (rust-lang/rust#140985)
- [Set `MSG_NOSIGNAL` for `UnixStream`]
  (rust-lang/rust#140005) This may change
  program behavior but results in the same behavior as other
  primitives (e.g., stdout, network sockets).  Programs relying on
  signals to terminate them should update handling of sockets to
  handle errors on write by exiting.
- [On Unix `std::env::home_dir` will use the fallback if the `HOME`
  environment variable is empty]
  (rust-lang/rust#141840)
- We now [reject unsupported `extern "{abi}"`s consistently in all
  positions] (rust-lang/rust#142134). This
  primarily affects the use of implementing traits on an `extern
  "{abi}"` function pointer, like `extern "stdcall" fn()`, on a
  platform that doesn't support that, like aarch64-unknown-linux-gnu.
  Direct usage of these unsupported ABI strings by declaring or
  defining functions was already rejected, so this is only a change
  for consistency.
- [const-eval: error when initializing a static writes to that static]
  (rust-lang/rust#143084)
- [Check that the `proc_macro_derive` macro has correct arguments
  when applied to the crate root]
  (rust-lang/rust#143607)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes Marks issues that should be documented in the release notes of the next release. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-lang Relevant to the language team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Writing to a static is somehow allowed while initializing that same static
5 participants