Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Various refactors to the LTO handling code #143388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 17, 2025
Merged

Various refactors to the LTO handling code #143388

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
653bb64
Remove LtoModuleCodegen
bjorn3 Jul 3, 2025
7fd78df
Move dcx creation into WriteBackendMethods::codegen
bjorn3 Jul 3, 2025
ee280a5
Fat LTO always produces a single object file, so -Zcombine-cgu has no…
bjorn3 Jul 3, 2025
797084d
Split generate_lto_work between fat and thin-LTO cases
bjorn3 Jul 3, 2025
332f1b1
Pass in autodiff items when starting the coordinator thread
bjorn3 Jul 3, 2025
779cb00
Move run_fat_lto call into execute_fat_lto_work_item
bjorn3 Jul 3, 2025
9a3aa8f
Remove unnecessary check for fat LTO
bjorn3 Jul 3, 2025
8d63c7a
Remove unused config param from WriteBackendMethods::autodiff
bjorn3 Jul 3, 2025
21026ca
Merge run_fat_lto, optimize_fat and autodiff into run_and_optimize_fa…
bjorn3 Jul 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove unused config param from WriteBackendMethods::autodiff
  • Loading branch information
@bjorn3
bjorn3 committed Jul 3, 2025
commit 8d63c7a1d68cd30383dceb03a76499c658fa7f40
1 change: 0 additions & 1 deletion compiler/rustc_codegen_gcc/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -437,7 +437,6 @@ impl WriteBackendMethods for GccCodegenBackend {
_cgcx: &CodegenContext<Self>,
_module: &ModuleCodegen<Self::Module>,
_diff_functions: Vec<AutoDiffItem>,
_config: &ModuleConfig,
) -> Result<(), FatalError> {
unimplemented!()
}
Expand Down
2 changes: 0 additions & 2 deletions compiler/rustc_codegen_llvm/src/builder/autodiff.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ use std::ptr;

use rustc_ast::expand::autodiff_attrs::{AutoDiffAttrs, AutoDiffItem, DiffActivity, DiffMode};
use rustc_codegen_ssa::ModuleCodegen;
use rustc_codegen_ssa::back::write::ModuleConfig;
use rustc_codegen_ssa::common::TypeKind;
use rustc_codegen_ssa::traits::BaseTypeCodegenMethods;
use rustc_errors::FatalError;
Expand Down Expand Up @@ -461,7 +460,6 @@ pub(crate) fn differentiate<'ll>(
module: &'ll ModuleCodegen<ModuleLlvm>,
cgcx: &CodegenContext<LlvmCodegenBackend>,
diff_items: Vec<AutoDiffItem>,
_config: &ModuleConfig,
) -> Result<(), FatalError> {
for item in &diff_items {
trace!("{}", item);
Expand Down
3 changes: 1 addition & 2 deletions compiler/rustc_codegen_llvm/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,13 +231,12 @@ impl WriteBackendMethods for LlvmCodegenBackend {
cgcx: &CodegenContext<Self>,
module: &ModuleCodegen<Self::Module>,
diff_fncs: Vec<AutoDiffItem>,
config: &ModuleConfig,
) -> Result<(), FatalError> {
if cgcx.lto != Lto::Fat {
let dcx = cgcx.create_dcx();
return Err(dcx.handle().emit_almost_fatal(AutoDiffWithoutLTO));
}
builder::autodiff::differentiate(module, cgcx, diff_fncs, config)
builder::autodiff::differentiate(module, cgcx, diff_fncs)
}
}

Expand Down
3 changes: 1 addition & 2 deletions compiler/rustc_codegen_ssa/src/back/write.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -999,8 +999,7 @@ fn execute_fat_lto_work_item<B: ExtraBackendMethods>(
B::run_fat_lto(cgcx, needs_fat_lto, import_only_modules).unwrap_or_else(|e| e.raise());

if !autodiff.is_empty() {
let config = cgcx.config(ModuleKind::Regular);
if let Err(err) = B::autodiff(cgcx, &module, autodiff, config) {
if let Err(err) = B::autodiff(cgcx, &module, autodiff) {
err.raise();
}
}
Expand Down
1 change: 0 additions & 1 deletion compiler/rustc_codegen_ssa/src/traits/write.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,6 @@ pub trait WriteBackendMethods: Clone + 'static {
cgcx: &CodegenContext<Self>,
module: &ModuleCodegen<Self::Module>,
diff_fncs: Vec<AutoDiffItem>,
config: &ModuleConfig,
) -> Result<(), FatalError>;
}

Expand Down