Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update the compiler-builtins subtree #143405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jul 10, 2025
Merged

Update the compiler-builtins subtree #143405

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
3dc3017
use `is_multiple_of` to check if an addr is aligned
folkertdev Jun 14, 2025
a413cca
use `extern "custom"` on naked functions with a custom calling conven…
folkertdev Jun 14, 2025
bcc96da
Add minimal triagebot config
Urgau Jun 14, 2025
9f4670f
symcheck: Add a wrapper around an archive
tgross35 Jun 14, 2025
962ff16
Use `asm_cfg` in `probestack`
folkertdev Jun 24, 2025
76b9fbf
apply suggestions for clippy::manual_is_multiple_of in libm-test
quaternic Jun 29, 2025
a4d584e
josh-sync: Replace `#xxxx`-style links in messages
tgross35 Jun 14, 2025
6c42218
libm: Improved integer utilities, implement shifts and bug fixes for …
quaternic Jul 1, 2025
be35d37
Use the compiler to determine whether or not to enable `f16` and `f128`
tgross35 Jun 30, 2025
6ae56f4
Remove the `let_chains` feature now that it is stable
tgross35 Jul 4, 2025
e164811
symcheck: Make `target` a positional argument
tgross35 Jul 4, 2025
84060f6
symcheck: Improve diagnostics from spawned Cargo
tgross35 Jul 4, 2025
19ab646
Remove unused custom target JSON files
tgross35 Jul 5, 2025
016bc61
Test building custom targets and resolve an issue probing `rustc`
tgross35 Jul 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
symcheck: Improve diagnostics from spawned Cargo 
Rather than printing the entire JSON dump, use the rendered version.
  • Loading branch information
@tgross35
tgross35 committed Jul 4, 2025
commit 84060f608b375d77bed9845709d57441393ceed6
29 changes: 22 additions & 7 deletions library/compiler-builtins/crates/symbol-check/src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,9 +87,14 @@ fn host_target() -> String {
/// libraries.
fn exec_cargo_with_args(target: &str, args: &[&str]) -> Vec<PathBuf> {
let mut cmd = Command::new("cargo");
cmd.args(["build", "--target", target, "--message-format=json"])
.args(args)
.stdout(Stdio::piped());
cmd.args([
"build",
"--target",
target,
"--message-format=json-diagnostic-rendered-ansi",
])
.args(args)
.stdout(Stdio::piped());

println!("running: {cmd:?}");
let mut child = cmd.spawn().expect("failed to launch Cargo");
Expand All @@ -100,11 +105,21 @@ fn exec_cargo_with_args(target: &str, args: &[&str]) -> Vec<PathBuf> {

for line in reader.lines() {
let line = line.expect("failed to read line");
println!("{line}"); // tee to stdout

// Select only steps that create files
let j: Value = serde_json::from_str(&line).expect("failed to deserialize");
if j["reason"] != "compiler-artifact" {
let reason = &j["reason"];

// Forward output that is meant to be user-facing
if reason == "compiler-message" {
println!("{}", j["message"]["rendered"].as_str().unwrap());
} else if reason == "build-finished" {
println!("build finshed. success: {}", j["success"]);
} else if reason == "build-script-executed" {
let pretty = serde_json::to_string_pretty(&j).unwrap();
println!("build script output: {pretty}",);
}

// Only interested in the artifact list now
if reason != "compiler-artifact" {
continue;
}

Expand Down