Thanks to visit codestin.com
Credit goes to github.com

Skip to content

More carefully consider span context when suggesting remove &mut #143532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 9, 2025
Merged

More carefully consider span context when suggesting remove &mut #143532

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions compiler/rustc_trait_selection/src/error_reporting/traits/suggestions.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1511,12 +1511,15 @@ impl<'a, 'tcx> TypeErrCtxt<'a, 'tcx> {
'outer: loop {
while let hir::ExprKind::AddrOf(_, _, borrowed) = expr.kind {
count += 1;
let span = if expr.span.eq_ctxt(borrowed.span) {
expr.span.until(borrowed.span)
} else {
expr.span.with_hi(expr.span.lo() + BytePos(1))
};
let span =
if let Some(borrowed_span) = borrowed.span.find_ancestor_inside(expr.span) {
expr.span.until(borrowed_span)
} else {
break 'outer;
};

// Double check that the span we extracted actually corresponds to a borrow,
// rather than some macro garbage.
match self.tcx.sess.source_map().span_to_snippet(span) {
Ok(snippet) if snippet.starts_with("&") => {}
_ => break 'outer,
Expand Down
12 changes: 12 additions & 0 deletions tests/ui/suggestions/suggest-remove-refs-6.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
// Regression test for #143523.

trait Trait {}

impl Trait for Vec<i32> {}

fn foo(_: impl Trait) {}

fn main() {
foo(&mut vec![1]);
//~^ ERROR the trait bound `&mut Vec<{integer}>: Trait` is not satisfied
}
22 changes: 22 additions & 0 deletions tests/ui/suggestions/suggest-remove-refs-6.stderr
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
error[E0277]: the trait bound `&mut Vec<{integer}>: Trait` is not satisfied
--> $DIR/suggest-remove-refs-6.rs:10:9
|
LL | foo(&mut vec![1]);
| --- ^^^^^^^^^^^^ the trait `Trait` is not implemented for `&mut Vec<{integer}>`
| |
| required by a bound introduced by this call
|
note: required by a bound in `foo`
--> $DIR/suggest-remove-refs-6.rs:7:16
|
LL | fn foo(_: impl Trait) {}
| ^^^^^ required by this bound in `foo`
help: consider removing the leading `&`-reference
|
LL - foo(&mut vec![1]);
LL + foo(vec![1]);
|

error: aborting due to 1 previous error

For more information about this error, try `rustc --explain E0277`.
Loading