Resolver: Batched Import Resolution #145108

LorrensP-2158466 · 2025-08-08T15:54:37Z

Transforms the current algorithm for resolving imports to a batched algorithm. Every import in the indeterminate_imports set is resolved in isolation. This is the only real difference from the current algorithm.

r? petrochenkov

compiler/rustc_resolve/src/lib.rs

compiler/rustc_resolve/src/imports.rs

LorrensP-2158466 · 2025-08-11T19:29:42Z

Code looks a little better now and should be more correct than the previous commits, but I have yet to find a way to resolve the current test failures.

LorrensP-2158466 · 2025-08-11T20:34:04Z

Okey, I did fix core not being built, but those other errors happened again. We now resolve the prelude import path when we create such an import at build_reduced_graph phase.

petrochenkov · 2025-08-11T22:39:59Z

Could you update the tests to make CI green, so I can see the difference?
(Even if the changes do not seem correct.)

tests/ui/imports/ambiguous-9.rs

tests/ui/imports/glob-conflict-cross-crate-1.rs

tests/ui/proc-macro/derive-helper-legacy-spurious.rs

petrochenkov · 2025-08-12T17:43:51Z

Moving prelude_import processing to build_reduced_graph may also be necessary for #139493.

LorrensP-2158466 · 2025-08-12T17:49:54Z

I'll create a pr for it.

compiler/rustc_resolve/src/imports.rs

LorrensP-2158466 · 2025-08-28T16:31:04Z

@rustbot ready

petrochenkov · 2025-08-28T22:10:06Z

This should be ready for crater.
@bors try

…=<try> Resolver: Batched Import Resolution

rust-bors · 2025-08-29T00:27:32Z

☀️ Try build successful (CI)
Build commit: ae40d86 (ae40d86d689c7b8b0a48c1e4b9d38e02bc2beab1, parent: 35d55b34bffd51384ac430cc20852b7d16dd5a90)

petrochenkov · 2025-08-29T07:40:50Z

@craterbot check

craterbot · 2025-08-29T07:41:13Z

👌 Experiment pr-145108 created and queued.
🤖 Automatically detected try build ae40d86
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2025-09-04T11:42:50Z

🚧 Experiment pr-145108 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2025-09-06T03:48:38Z

🎉 Experiment pr-145108 is completed!
📊 3514 regressed and 1443 fixed (690664 total)
📊 2000 spurious results on the retry-regessed-list.txt, consider a retry¹ if this is a significant amount.
📰 Open the summary report.

⚠️ If you notice any spurious failure please add them to the denylist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

re-run the experiment with crates=https://crater-reports.s3.amazonaws.com/pr-145108/retry-regressed-list.txt ↩

petrochenkov · 2025-09-22T16:51:09Z

Waiting on author to analyze the crater regressions.
@rustbot author

rustbot · 2025-09-22T16:51:13Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

LorrensP-2158466 · 2025-09-25T17:35:15Z

compiler/rustc_resolve/src/imports.rs

-            let error_ambiguity = binding.is_ambiguity_recursive() && !binding.warn_ambiguity;
-            if res != def::Res::Err && !error_ambiguity {
+            if res != def::Res::Err && !binding.is_ambiguity_recursive() {


I think that the crater regressions originate from this, because these errors only originate when we import from external crates. I could be entirely wrong, just documenting.

…r=petrochenkov Resolve: (Ref)Cell wrappers to deny mutation during spec resolution. Introduces wrappers around `Cell` and `RefCell` that only allow mutation when we are not in speculative resolution. This is preparatory work for rust-lang#145108. It would allow us to make `ImportData` and `ModuleData` sync and send safe. r? `@petrochenkov`

…r=petrochenkov Resolve: (Ref)Cell wrappers to deny mutation during spec resolution. Introduces wrappers around `Cell` and `RefCell` that only allow mutation when we are not in speculative resolution. This is preparatory work for rust-lang#145108. It would allow us to make `ImportData` and `ModuleData` sync and send safe. r? ``@petrochenkov``

Rollup merge of #146283 - LorrensP-2158466:resolve-cm-cell, r=petrochenkov Resolve: (Ref)Cell wrappers to deny mutation during spec resolution. Introduces wrappers around `Cell` and `RefCell` that only allow mutation when we are not in speculative resolution. This is preparatory work for #145108. It would allow us to make `ImportData` and `ModuleData` sync and send safe. r? ``@petrochenkov``

bors · 2025-09-26T12:00:07Z

☔ The latest upstream changes (presumably #147054) made this pull request unmergeable. Please resolve the merge conflicts.

rustbot assigned petrochenkov Aug 8, 2025

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 8, 2025

This comment has been minimized.

Sign in to view

LorrensP-2158466 commented Aug 8, 2025

View reviewed changes

compiler/rustc_resolve/src/lib.rs Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

LorrensP-2158466 marked this pull request as ready for review August 11, 2025 08:37

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 11, 2025

LorrensP-2158466 commented Aug 11, 2025

View reviewed changes

compiler/rustc_resolve/src/imports.rs Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

petrochenkov reviewed Aug 11, 2025

View reviewed changes

petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 11, 2025

This comment has been minimized.

Sign in to view

LorrensP-2158466 force-pushed the batched-import-resolution branch from a3f8ae2 to 4a2a0dc Compare August 11, 2025 20:37

This comment has been minimized.

Sign in to view

petrochenkov added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 12, 2025

LorrensP-2158466 commented Aug 12, 2025

View reviewed changes

tests/ui/imports/ambiguous-9.rs Show resolved Hide resolved

LorrensP-2158466 commented Aug 12, 2025

View reviewed changes

tests/ui/imports/glob-conflict-cross-crate-1.rs Show resolved Hide resolved

LorrensP-2158466 commented Aug 12, 2025

View reviewed changes

tests/ui/proc-macro/derive-helper-legacy-spurious.rs Show resolved Hide resolved

LorrensP-2158466 commented Aug 12, 2025

View reviewed changes

tests/ui/proc-macro/derive-helper-legacy-spurious.rs Show resolved Hide resolved

petrochenkov reviewed Aug 12, 2025

View reviewed changes

compiler/rustc_resolve/src/imports.rs Outdated Show resolved Hide resolved

compiler/rustc_resolve/src/imports.rs Outdated Show resolved Hide resolved

compiler/rustc_resolve/src/imports.rs Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

disallow ambiguous names imported from external crates

2c05214

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 28, 2025

This comment has been minimized.

Sign in to view

bless test

0eba015

This comment has been minimized.

Sign in to view

rust-bors bot added a commit that referenced this pull request Aug 28, 2025

Auto merge of #145108 - LorrensP-2158466:batched-import-resolution, r…

ae40d86

…=<try> Resolver: Batched Import Resolution

petrochenkov added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 28, 2025

craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Sep 6, 2025

LorrensP-2158466 mentioned this pull request Sep 6, 2025

Resolve: (Ref)Cell wrappers to deny mutation during spec resolution. #146283

Merged

petrochenkov mentioned this pull request Sep 16, 2025

Having made lint ambiguous_glob_imports deny-by-default and report-in-deps #146651

Closed

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 22, 2025

LorrensP-2158466 commented Sep 25, 2025

View reviewed changes

Resolver: Batched Import Resolution #145108

Are you sure you want to change the base?

Resolver: Batched Import Resolution #145108

Conversation

LorrensP-2158466 commented Aug 8, 2025

Uh oh!

This comment has been minimized.

Uh oh!

This comment has been minimized.

This comment has been minimized.

Uh oh!

This comment has been minimized.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

LorrensP-2158466 commented Aug 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

LorrensP-2158466 commented Aug 11, 2025

Uh oh!

This comment has been minimized.

petrochenkov commented Aug 11, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

petrochenkov commented Aug 12, 2025

Uh oh!

LorrensP-2158466 commented Aug 12, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

LorrensP-2158466 commented Aug 28, 2025

Uh oh!

This comment has been minimized.

petrochenkov commented Aug 28, 2025

Uh oh!

This comment has been minimized.

rust-bors bot commented Aug 29, 2025

Uh oh!

petrochenkov commented Aug 29, 2025

Uh oh!

craterbot commented Aug 29, 2025

Uh oh!

craterbot commented Sep 4, 2025

Uh oh!

craterbot commented Sep 6, 2025

Footnotes

Uh oh!

petrochenkov commented Sep 22, 2025

Uh oh!

rustbot commented Sep 22, 2025

Uh oh!

LorrensP-2158466 Sep 25, 2025

Choose a reason for hiding this comment

Uh oh!

bors commented Sep 26, 2025

Uh oh!

Uh oh!

LorrensP-2158466 commented Aug 11, 2025 •

edited

Loading