Thanks to visit codestin.com
Credit goes to github.com

Skip to content

rustdoc: correct negative-to-implicit discriminant display #145216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 12, 2025
Merged

rustdoc: correct negative-to-implicit discriminant display #145216

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
de13718
test: Add rustdoc test for enum negative overflow
eval-exec Aug 10, 2025
20a134f
rustdoc: Use `discr`s `Display` impl to render the value with the cor…
eval-exec Aug 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
test: Add rustdoc test for enum negative overflow
  • Loading branch information
@eval-exec
eval-exec committed Aug 10, 2025
commit de13718c66965852ba8970781908fa1eda9a54b9
22 changes: 22 additions & 0 deletions tests/rustdoc/enum/enum-variant-value.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,3 +189,25 @@ pub use bar::P;
//@ has - '//*[@id="variant.A"]/h3' 'A(u32)'
//@ matches - '//*[@id="variant.B"]/h3' '^B$'
pub use bar::Q;

// Ensure signed implicit discriminants are rendered correctly after a negative explicit value.
//@ has 'foo/enum.R.html'
//@ has - '//*[@class="rust item-decl"]/code' 'A = -2,'
//@ has - '//*[@class="rust item-decl"]/code' 'B = -1,'
//@ matches - '//*[@id="variant.A"]/h3' '^A = -2$'
//@ matches - '//*[@id="variant.B"]/h3' '^B = -1$'
pub enum R {
A = -2,
B,
}

// Also check that incrementing -1 yields 0 for the next implicit variant.
//@ has 'foo/enum.S.html'
//@ has - '//*[@class="rust item-decl"]/code' 'A = -1,'
//@ has - '//*[@class="rust item-decl"]/code' 'B = 0,'
//@ matches - '//*[@id="variant.A"]/h3' '^A = -1$'
//@ matches - '//*[@id="variant.B"]/h3' '^B = 0$'
pub enum S {
A = -1,
B,
}
Loading