Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@dpaoliello
Copy link
Contributor

Bumps opener to 0.8 and junction to 1.3 - this removes the dependency on winapi (unless the build-metrics feature is enabled) and replaces the usage of windows-sys 0.52 with 0.60.

Together this means that bootstrap can now be built for Arm64EC.

@rustbot
Copy link
Collaborator

rustbot commented Sep 3, 2025

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Sep 3, 2025
@dpaoliello
Copy link
Contributor Author

FYI, I'm also looking into the dependencies that are pulling in windows-sys 0.59 to see if they can move to 0.60 so that bootstrap can use a single version.

@lqd
Copy link
Member

lqd commented Sep 3, 2025

FYI, I'm also looking into the dependencies that are pulling in windows-sys 0.59 to see if they can move to 0.60 so that bootstrap can use a single version.

Would that remove the duplicate windows-targets?

@dpaoliello
Copy link
Contributor Author

Would that remove the duplicate windows-targets?

Yep

@jieyouxu
Copy link
Member

jieyouxu commented Sep 4, 2025

@bors try jobs=aarch64-msvc-1,x86_64-msvc-1

@rust-bors

This comment has been minimized.

rust-bors bot added a commit that referenced this pull request Sep 4, 2025
Update bootstrap's dependencies to remove winapi and old windows-sys

try-job: aarch64-msvc-1
try-job: x86_64-msvc-1
@rust-bors
Copy link

rust-bors bot commented Sep 4, 2025

☀️ Try build successful (CI)
Build commit: 77c441e (77c441e2ff841b085212752dcd7d6e3e1b353a0f, parent: a1208bf765ba783ee4ebdc4c29ab0a0c215806ef)

Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jieyouxu
Copy link
Member

jieyouxu commented Sep 4, 2025

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Sep 4, 2025

📌 Commit 31d1d82 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 4, 2025
Zalathar added a commit to Zalathar/rust that referenced this pull request Sep 4, 2025
Update bootstrap's dependencies to remove winapi and old windows-sys

Bumps `opener` to 0.8 and `junction` to 1.3 - this removes the dependency on `winapi` (unless the `build-metrics` feature is enabled) and replaces the usage of `windows-sys` 0.52 with 0.60.

Together this means that bootstrap can now be built for Arm64EC.
bors added a commit that referenced this pull request Sep 4, 2025
Rollup of 5 pull requests

Successful merges:

 - #145682 (Promote aarch64-pc-windows-msvc to Tier 1)
 - #145690 (Implement Integer funnel shifts)
 - #146119 (compiletest: Implement an experimental `--new-output-capture` mode)
 - #146168 (Update bootstrap's dependencies to remove winapi and old windows-sys)
 - #146182 (Don't require next-solver `ProbeRef` to be `Copy`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit fbaf7ff into rust-lang:master Sep 4, 2025
11 checks passed
@rustbot rustbot added this to the 1.91.0 milestone Sep 4, 2025
rust-timer added a commit that referenced this pull request Sep 4, 2025
Rollup merge of #146168 - dpaoliello:bootstrapdeps, r=jieyouxu

Update bootstrap's dependencies to remove winapi and old windows-sys

Bumps `opener` to 0.8 and `junction` to 1.3 - this removes the dependency on `winapi` (unless the `build-metrics` feature is enabled) and replaces the usage of `windows-sys` 0.52 with 0.60.

Together this means that bootstrap can now be built for Arm64EC.
@dpaoliello dpaoliello deleted the bootstrapdeps branch September 4, 2025 17:54
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Sep 5, 2025
Rollup of 5 pull requests

Successful merges:

 - rust-lang/rust#145682 (Promote aarch64-pc-windows-msvc to Tier 1)
 - rust-lang/rust#145690 (Implement Integer funnel shifts)
 - rust-lang/rust#146119 (compiletest: Implement an experimental `--new-output-capture` mode)
 - rust-lang/rust#146168 (Update bootstrap's dependencies to remove winapi and old windows-sys)
 - rust-lang/rust#146182 (Don't require next-solver `ProbeRef` to be `Copy`)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants