Trim paths less in MIR dumping #146391
Merged
Trim paths less in MIR dumping #146391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. I'm surprised we don't have more diff in the mir-opt tests, but I suppose that's more because our tests are based on tiny programs that mostly don't use the sysroot. @bors r+ |
|
I think its because most tests have no need to check the MIR of std's functions. Its always better to just copy that code into the test itself. |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Sep 10, 2025
Trim paths less in MIR dumping With this PR, the paths MIR dump filters and that are printed at the start of a dump file are no longer trimmed. They don't include the crate that is being compiled, however.
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Sep 10, 2025
Trim paths less in MIR dumping With this PR, the paths MIR dump filters and that are printed at the start of a dump file are no longer trimmed. They don't include the crate that is being compiled, however.
bors
added a commit
that referenced
this pull request
Sep 10, 2025
Rollup of 6 pull requests Successful merges: - #144765 (inclusive `Range`s: change `end` to `last`) - #145177 (std: move `thread` into `sys`) - #146178 (Implement `#[rustc_align_static(N)]` on `static`s) - #146368 (CI: rfl: move job forward to Linux v6.17-rc5 to remove temporary commits) - #146378 (Update wasm-component-ld to 0.5.17) - #146391 (Trim paths less in MIR dumping) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
that referenced
this pull request
Sep 10, 2025
Rollup of 5 pull requests Successful merges: - #144765 (inclusive `Range`s: change `end` to `last`) - #146178 (Implement `#[rustc_align_static(N)]` on `static`s) - #146368 (CI: rfl: move job forward to Linux v6.17-rc5 to remove temporary commits) - #146378 (Update wasm-component-ld to 0.5.17) - #146391 (Trim paths less in MIR dumping) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
that referenced
this pull request
Sep 10, 2025
Rollup of 5 pull requests Successful merges: - #144765 (inclusive `Range`s: change `end` to `last`) - #146178 (Implement `#[rustc_align_static(N)]` on `static`s) - #146368 (CI: rfl: move job forward to Linux v6.17-rc5 to remove temporary commits) - #146378 (Update wasm-component-ld to 0.5.17) - #146391 (Trim paths less in MIR dumping) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Sep 10, 2025
Rollup merge of #146391 - beepster4096:trimnt, r=saethlin Trim paths less in MIR dumping With this PR, the paths MIR dump filters and that are printed at the start of a dump file are no longer trimmed. They don't include the crate that is being compiled, however.
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Sep 11, 2025
Rollup of 5 pull requests Successful merges: - rust-lang/rust#144765 (inclusive `Range`s: change `end` to `last`) - rust-lang/rust#146178 (Implement `#[rustc_align_static(N)]` on `static`s) - rust-lang/rust#146368 (CI: rfl: move job forward to Linux v6.17-rc5 to remove temporary commits) - rust-lang/rust#146378 (Update wasm-component-ld to 0.5.17) - rust-lang/rust#146391 (Trim paths less in MIR dumping) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, the paths MIR dump filters and that are printed at the start of a dump file are no longer trimmed. They don't include the crate that is being compiled, however.