Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Re-enable assertions on macOS #146513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Re-enable assertions on macOS #146513

wants to merge 2 commits into from

Conversation

madsmtm
Copy link
Contributor

@madsmtm madsmtm commented Sep 13, 2025 •
edited
Loading

These were previously disabled, in part for performance reasons, in part due to needing availability symbols __isPlatformVersionAtLeast and __isOSVersionAtLeast that compiler-builtins did not provide, see #62592 (comment) and #134275 (comment) for failed checks.

Since #138944 though, std now provides these symbols, so we should be able to re-enable LLVM assertions, debug assertions and overflow checks.

Fixes #59637.

r? ghost (I'll need to see if I can get this working first).
try-job: *apple*

@madsmtm madsmtm added O-macos Operating system: macOS T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. A-CI Area: Our Github Actions CI labels Sep 13, 2025
@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 13, 2025
@madsmtm
Copy link
Contributor Author

madsmtm commented Sep 13, 2025

@bors try

rust-bors bot added a commit that referenced this pull request Sep 13, 2025
@rust-bors
Auto merge of #146513 - madsmtm:apple-reenable-assertions, r=<try>
beeae75 
Re-enable assertions on macOS

try-job: `*apple*`
@rust-bors

This comment has been minimized.

Sign in to view
@rust-log-analyzer
Copy link
Collaborator

The job dist-apple-various-alt failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
[RUSTC-TIMING] tikv_jemalloc_sys test:false 0.053
[RUSTC-TIMING] rustc_driver_impl test:false 14.341
error: linking with `cc` failed: exit status: 1
  |
  = note:  "cc" "-Wl,-exported_symbols_list" "-Wl,/var/folders/y6/nj790rtn62lfktb1sh__79hc0000gn/T/rustcsN5YIM/list" "/var/folders/y6/nj790rtn62lfktb1sh__79hc0000gn/T/rustcsN5YIM/symbols.o" "<1 object files omitted>" "/var/folders/y6/nj790rtn62lfktb1sh__79hc0000gn/T/rustcsN5YIM/rmeta.o" "<1 object files omitted>" "/Users/runner/work/rust/rust/build/aarch64-apple-darwin/stage1-rustc/aarch64-apple-darwin/release/deps/{librustc_driver_impl-a1e440105fb5f0aa,libctrlc-1fe558df91c4e70c,libnix-6944ba10ddb17b53,librustc_log-e860406a97137f50,libtracing_tree-b7389ab0b3f0e017,libtracing_log-01fbdad9d1fd0f95,libnu_ansi_term-059bfdacda8fa9a3,libtracing_subscriber-82736d12c477255a,libnu_ansi_term-64db5135cb3681df,liboverload-fe338846716e33d5,libsharded_slab-3f4afb6a1459f412,liblazy_static-02c7dd2ba84b3e7b,libmatchers-ff02b3a9fa5d1edf,libregex_automata-b7b8ca420bef1c87,libregex_syntax-6b9a8caba5298e13,libthread_local-1a462e2aa4a3147e,libjiff-59335db7ceccbcdf,librustc_public-e775b462eb3da5a1,librustc_public_bridge-65ed9d63adaf1d13,librustc_interface-e4e489d524c259df,librustc_codegen_llvm-f35ecbef28f52096,librustc_llvm-311e714f896fc95d,librustc_sanitizers-c1d0beabdf19ffff,librustc_hir_typeck-bc9ed6bc4bf572ed,librustc_hir_analysis-229828531e13d929,librustc_monomorphize-9230b245cb0c7046,librustc_mir_transform-94befbec81edb22e,librustc_mir_build-9445d3b45959bc61,librustc_pattern_analysis-16ac05059515ca50,librustc_borrowck-3c8a74ffe1f560ea,librustc_traits-c7522587bd7c5c51,librustc_const_eval-32e984212d0e1bcc,librustc_mir_dataflow-e0adc191cf5b54f8,librustc_builtin_macros-a87d085bc91c4a5a,librustc_resolve-07bcb65aa8bb74ac,libpulldown_cmark-5e233773f91784b5,libunicase-29a90fa3ee2dc78e,libpulldown_cmark_escape-297508ac870be063,librustc_passes-8f4364e1d265d291,librustc_ast_lowering-65515037e9a6609f,librustc_privacy-3a124a07045c5e58,librustc_ty_utils-5ca0fc5e03a8444d,librustc_lint-2027d0dc050be631,libunicode_security-050bb01e101c63fa,libunicode_script-5dc4af36af0edc93,librustc_query_impl-87bbee710c10c38b,librustc_codegen_ssa-4d17c5521f146415,libwasm_encoder-a12199558b6e35d9,libleb128-9063f1b9b097ebea,libthorin-330987a59ba1750f,libgimli-97f51010a8b66656,libfallible_iterator-b075d694d35d1e5d,libobject-a2d33433f660ca59,libruzstd-6bc224616993678a,libtwox_hash-728043066d2f1a83,librand-1562aa6848c19ceb,librand_chacha-e02b60ffb4bba8f1,librand_core-c9908c3067bbe81d,libgetrandom-5d2f3affa45f4ca9,libstatic_assertions-3c0f3830dd059e18,libflate2-fc6a9d439304783a,libminiz_oxide-b33562e40edf0b51,libadler2-6b951cee748cd59e,libbstr-0d805c5ead51a361,librustc_trait_selection-952278027af43365,librustc_next_trait_solver-29c1610a1742fd87,librustc_parse_format-5b6cca7a22e96fdd,librustc_transmute-de0c7de3920e64b3,librustc_infer-87915a1bee99405b,librustc_symbol_mangling-5365d7b4142f181b,librustc_demangle-c818932f32540df5,libpunycode-9d147e4fa9e57d47,libpathdiff-e2aed08e6f64af05,libregex-98dc8e6ba6529605,libcc-c845d277499859aa,libshlex-f86f8c37e6b1a734,libar_archive_writer-f7c75176bf45b287,librustc_metadata-29090afc74203f7f,liblibloading-9b18efc7f052350f,librustc_incremental-89d8e8a4c20796f1,librustc_expand-b1b0467f9a646890,librustc_ast_passes-15835b5751fdb967,librustc_proc_macro-629d018087ba9460,librustc_attr_parsing-3f01b1e9109a49ce,librustc_parse-3f3180941d48717c,libunicode_normalization-ce754f50160741c1,libtinyvec-cb983ee63b82c107,libtinyvec_macros-5f2f3a856e33a365,librustc_middle-71846ec669c95ac2,librustc_apfloat-8030fe56c5e2d798,libgsgdt-ff83f2cb3dfe7ca6,libpolonius_engine-6be47c1f032c1f90,libdatafrog-e7de0f017cad9e6a,librustc_query_system-2a7db706463c315e,librustc_type_ir-fc4c271e26a34136,librustc_session-78be51f2fc9ac4f2,libgetopts-4cedcfd068527a76,librustc_feature-5be83104b8c26c0d,librustc_hir_pretty-356b549f3af98598,librustc_errors-52991087aa84fcd1,libtermize-c28a0631a3bb44c0,librustc_error_codes-c839d61a165fef30,libannotate_snippets-f72585379d196670,libanstyle-34b466f04e3e35ce,libtermcolor-18558cda89f5e2e8,librustc_lint_defs-e3caa5710b3e3e5e,librustc_hir-e797fe6c18b61404,libodht-a078fe3758a030f5,librustc_hir_id-82eb4a5ed0d2b695,librustc_target-7019bbff3371ab9e,libserde_path_to_error-269ca7c286c79a85,libschemars-5fd14f1ab57d7b38,libdyn_clone-4afe72165e56433f,libref_cast-95ebd905d8408bda,libobject-bacf3ed5b473104f,libcrc32fast-14d0ecd877a45e81,libwasmparser-050cd3519a71119b,librustc_fs_util-db01657de3ecf546,libserde_json-f3ec7f867897af8f,libryu-b637b8684639e00d,libserde-8b034c4fd1e9e3d8,librustc_abi-ff484b1aa5821670,librand_xoshiro-d9b9a7dbda7f9a83,librustc_error_messages-ac070968ac2e13c0,librustc_baked_icu_data-6fc081a5745bcf96,libicu_list-37aaf9c13e65d685,libregex_automata-b3aa83cb95c69270,libaho_corasick-782a8f21ae050499,libregex_syntax-fdd5581a576f3fa3,libicu_locale-49fba208c2c93172,libicu_locale_data-5a1b72c6a3e35d47,libicu_collections-ed28d2d31018373b,libpotential_utf-d60180590b3e0427,libicu_provider-36ba6af857b99a21,libzerotrie-b9e0e599ee16a55d,libicu_locale_core-2bb1a0dcdaf352cb,libwriteable-45d8964d5a4c7c7b,liblitemap-52329b2514d5cceb,librustc_ast_pretty-d012b64a8b981c91,librustc_lexer-2bc50c7058167597,libunicode_xid-4a1cb50881f08110,libunicode_properties-2864e06940f73b82,libitertools-3d4efcf555a56d13,libfluent_bundle-f8b16f4f10abcce5,libfluent_langneg-69cbd35267f0a684,libintl_pluralrules-56c768db92dbb081,libself_cell-b830d17461bdcddb,libintl_memoizer-00ddb1406bd46786,libtype_map-5a85988c29375192,libunic_langid-6321a211694c71a0,libunic_langid_macros-647b78102dc48890,libunic_langid_impl-3737e098d9b26190,libtinystr-2bbd7f9cc2b72e7a,libzerovec-f9be583074947475,libyoke-a632e08388292033,libzerofrom-80b631777e6a3cb9,libfluent_syntax-dd75475f2e4e83f3,libthiserror-b3a7af228bcf0bde,librand-68686a86c3deb1da,librand_chacha-cc983a840bb2b56e,libppv_lite86-42da701e4dd6b13b,libzerocopy-834d6c75911b99bb,librand_core-a31917d0229a8ad7,librustc_ast-f5cd472496c7e9f4,libmemchr-a722b22690bd5c39,librustc_ast_ir-e7fc851a237265e6,librustc_literal_escaper-b4ec182d04ff452e,librustc_span-f01d92527a7fcd57,libunicode_width-46c9d9bf853e267c,libblake3-3a90ca850488a653,libconstant_time_eq-df821d3db2b0d574,libarrayref-42a48f8feb54f9e2,libitoa-086254c019568ee8,libscoped_tls-aad9d022073a8feb,libsha2-93b976a277bbab24,libsha1-fae0823af06e2e3e,libmd5-e3dc8d0940100ff7,libdigest-fd940abdac169d94,libblock_buffer-3aa0911d898f5713,libcrypto_common-c075793aa9fc044c,libgeneric_array-fd869bc544e2be4d,libtypenum-3a7aa1d0befd7a52,librustc_data_structures-354199d3dd612068,libelsa-baa952ea5ee00e3d,libstable_deref_trait-b9153c47b12a27f3,librustc_thread_pool-9fb7993c8987ff6a,libcrossbeam_deque-9474e0f5f05e75b0,libcrossbeam_epoch-2ddd10b1c396a7b3,libcrossbeam_utils-740065fb8b6b4572,libstacker-122304290e485aea,libpsm-69b1a152147e6426,libmemmap2-aa1f8ec805c8c2e9,librustc_arena-f72f7b39b3449f99,libtempfile-33d34a203673e15d,libgetrandom-e6738076742e73eb,libfastrand-9c551ccf2ee69e67,librustix-b0a5eb8d55c196b7,libbitflags-30a19a3b25f64a3f,liberrno-efc99bc1238936e2,libarrayvec-17bd761c0fff876c,libeither-15ca068d0d3bc825,libmeasureme-777bf9ba15fef674,librustc_hash-58ef6f76228e71f0,librustc_graphviz-581e7b1ac623a20a,libparking_lot-a3949c4ceb21ca7f,libparking_lot_core-a25b58244032f11f,libcfg_if-22fee21edc5dfc13,liblock_api-c64ec1c37dcceda2,libscopeguard-6fc5ad90c01a5da1,libjobserver-9167f4af6de2ccf7,liblibc-247586084529bb1e,libtracing-12c0552226e62cb5,libpin_project_lite-b9cad5ac896b0aee,libtracing_core-42b1c8fc1ae233d0,libonce_cell-44d79381f0983447,librustc_hash-9d1dbd5760dbd48a,librustc_index-a6bfd035c9b6f443,librustc_serialize-9cf874eae3e1c083,libindexmap-217a6b2b6c204e96,libhashbrown-e81e22b9008d0e8c,libfoldhash-a921e40cee36ec3c,libequivalent-c00c93587fd318bb,libthin_vec-59a87b607be30716,librustc_hashes-439746d61c1b62ad,librustc_stable_hash-e2f2eaf4355f3a09,libsmallvec-e3417ea4f08d26b4,libena-d64d57468b226654,liblog-c00c46b3034c86b8}.rlib" "<sysroot>/lib/rustlib/aarch64-apple-darwin/lib/{libstd-*,libpanic_unwind-*,libobject-*,libmemchr-*,libaddr2line-*,libgimli-*,librustc_demangle-*,libstd_detect-*,libhashbrown-*,librustc_std_workspace_alloc-*,libminiz_oxide-*,libadler2-*,libunwind-*,libcfg_if-*,liblibc-*,librustc_std_workspace_core-*,liballoc-*,libcore-*,libcompiler_builtins-*}.rlib" "-lm" "-lz" "-lc++" "-liconv" "-lSystem" "-lc" "-lm" "-arch" "arm64" "-mmacosx-version-min=11.0.0" "-L" "/Users/runner/work/rust/rust/build/aarch64-apple-darwin/stage1-rustc/aarch64-apple-darwin/release/build/psm-1e1f372fa6f7e128/out" "-L" "/Users/runner/work/rust/rust/build/aarch64-apple-darwin/stage1-rustc/aarch64-apple-darwin/release/build/blake3-e2361232ac099fd3/out" "-L" "/Users/runner/work/rust/rust/build/aarch64-apple-darwin/stage1-rustc/aarch64-apple-darwin/release/build/rustc_llvm-ab8712ef46aa823e/out" "-L" "/Users/runner/work/rust/rust/build/aarch64-apple-darwin/llvm/lib" "-o" "/Users/runner/work/rust/rust/build/aarch64-apple-darwin/stage1-rustc/aarch64-apple-darwin/release/deps/librustc_driver-1dfbe6cd62776b18.dylib" "-Wl,-dead_strip" "-dynamiclib" "-Wl,-install_name" "-Wl,@rpath/librustc_driver-1dfbe6cd62776b18.dylib" "-nodefaultlibs" "-Wl,-rpath,@loader_path/../lib"
  = note: some arguments are omitted. use `--verbose` to show all linker arguments
  = note: ld: warning: ignoring duplicate libraries: '-lm'
          ld: Undefined symbols:
            ___isPlatformVersionAtLeast, referenced from:
                llvm::SignpostEmitterImpl::startInterval(void const*, llvm::StringRef) in librustc_llvm-311e714f896fc95d.rlib[2446](Signposts.cpp.o)
                llvm::SignpostEmitterImpl::startInterval(void const*, llvm::StringRef) in librustc_llvm-311e714f896fc95d.rlib[2446](Signposts.cpp.o)
                llvm::SignpostEmitterImpl::endInterval(void const*, llvm::StringRef) in librustc_llvm-311e714f896fc95d.rlib[2446](Signposts.cpp.o)
                llvm::SignpostEmitterImpl::endInterval(void const*, llvm::StringRef) in librustc_llvm-311e714f896fc95d.rlib[2446](Signposts.cpp.o)
                llvm::SignpostEmitterImpl::getSignpostForObject(void const*) in librustc_llvm-311e714f896fc95d.rlib[2446](Signposts.cpp.o)
          clang: error: linker command failed with exit code 1 (use -v to see invocation)
          

[RUSTC-TIMING] rustc_driver test:false 6.954
error: could not compile `rustc_driver` (lib) due to 1 previous error
Bootstrap failed while executing `dist bootstrap --include-default-paths --host= --target=aarch64-apple-ios,x86_64-apple-ios,aarch64-apple-ios-sim,aarch64-apple-ios-macabi,x86_64-apple-ios-macabi`

@rust-bors
Copy link

rust-bors bot commented Sep 13, 2025

💔 Test for beeae75 failed: CI. Failed jobs:

@madsmtm
Copy link
Contributor Author

madsmtm commented Sep 13, 2025 •
edited
Loading

Hmm, might need a stage0 bump, waiting for that:
@rustbot blocked

@rustbot rustbot added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc O-macos Operating system: macOS S-blocked Status: Blocked on something else such as an RFC or other implementation work. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Re-enable LLVM and debug assertions for slow builders
3 participants
@madsmtm @rust-log-analyzer @rustbot