Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

matthiaskrgr
Copy link
Member

@matthiaskrgr matthiaskrgr commented Sep 28, 2025

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

Zalathar and others added 30 commits September 19, 2025 14:41
In each of these casts, the LHS is already `u64`.
These should have been removed earlier, when we switched to the corresponding
LLVM-C bindings.
The descriptions of the alternate forms of Octal and Binary were swapped
in the doc comment for FormattingOptions::alternate().
The ability to define an attribute macro with `macro_rules!` is tracked at rust-lang#143547, not rust-lang#83527
This patch changes `bump-stage0` to include:

* The sha256 hash of the channel manifest used to create `src/stage0`.
* The rust and rustfmt git commit in `src/stage0`.
* Hashes of all the artifacts, like the source tarball, in `src/stage0`.

Combined this will allow for:

* Projects that bootstrap their own compiler, such as Fuchsia, or users
  of [bootstrap], to build their compilers offline without needing to
  communicate with static.rust-lang.org.

* Auditors to detect if the channel manifest, and all the artifacts
  inside the manifest, were modified after it was used to generate
  `src/stage0`. Furthermore, if they did find modified artifacts, they
  could determine if the Rust Signing Key was compromised by checking if
  any modified file was signed properly.

Finally, it allows regeneration of `src/stage0` when specifying both the
day of the build for rust, and the day of the build for rustfmt, which
can allow a maintainer to regenerate `src/stage0` to verify nothing
changed.

[bootstrap]: https://github.com/dtolnay/bootstrap
[mrustc]: https://github.com/thepowersgang/mrustc
It enables automatic check changes of Python/C++/JS
before pushing the changes to remote repository.
Those checks happen only when the target type of file is changed.
Otherwise it does not install any dependencies (venv and/or node_modules).
Note that shellcheck and spellcheck are not included in this change, because:
1. Unlike venv/node_modules, shellcheck is not installed automatically by the command, and
2. spellcheck is built whenever pre-push script is run, it forces developer to wait extra time
So not to break the current productivity, this commit skips them.
…lacrum

Include additional hashes in src/stage0

This patch changes `bump-stage0` to include:

* The sha256 hash of the channel manifest used to create `src/stage0`.
* The rust and rustfmt git commit in `src/stage0`.
* Hashes of all the artifacts, like the source tarball, in `src/stage0`.

Combined this will allow for:

* Projects that bootstrap their own compiler, such as Fuchsia, or users of [bootstrap], to build their compilers offline without needing to communicate with static.rust-lang.org.

* Auditors to detect if the channel manifest, and all the artifacts inside the manifest, were modified after it was used to generate `src/stage0`. Furthermore, if they did find modified artifacts, they could determine if the Rust Signing Key was compromised by checking if any modified file was signed properly.

finally, it allows regeneration of `src/stage0` when specifying both the day of the build for rust, and the day of the build for rustfmt, which can allow a maintainer to regenerate `src/stage0` to verify nothing changed.

[bootstrap]: https://github.com/dtolnay/bootstrap
[mrustc]: https://github.com/thepowersgang/mrustc
Clarified error note for usize range matching

Fixes rust-lang#146476

This is kinda rough, but it gets the point across a little better and stays short.
cg_llvm: Replace some DIBuilder wrappers with LLVM-C API bindings (part 5)

- Part of rust-lang#134001
- Follow-up to rust-lang#146673

---

This is another batch of LLVMDIBuilder binding migrations, replacing some our own LLVMRust bindings with bindings to upstream LLVM-C APIs.

Some of these are a little more complex than most of the previous migrations, because they split one LLVMRust binding into multiple LLVM bindings, but nothing too fancy.

This appears to be the last of the low-hanging fruit. As noted in rust-lang#134001 (comment), the remaining bindings are difficult or impossible to migrate at present.
…rkingjubilee

chore: removes deprecated discord.

This PR just changes the wording of the contributing document to remove the deprecated Discord.

Fixes rust-lang#146756.
…ating_write_str, r=GuillaumeGomez

[rustdoc] Finish getting rid of usages `write_str`

This PR, along with rust-lang#146933 , get rid of all the last usages of the `write_str` fn that was introduced back in rust-lang#136784 .

This *shouldn't* be rolled up along with rust-lang#146933 , since the later of the two to be merged will need to delete the no-longer-used `write_str` fn.
Commits can be reviewed separately.
Fix typo

Noticed this when looking at the source on doc.rust-lang.org
@rustbot rustbot added A-compiletest Area: The compiletest test runner A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-meta Area: Issues & PRs about the rust-lang/rust repository itself A-testsuite Area: The testsuite used to check the correctness of rustc O-unix Operating system: Unix-like S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-release Relevant to the release subteam, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) rollup A PR which is a rollup labels Sep 28, 2025
@matthiaskrgr
Copy link
Member Author

@bors r+ rollup=never p=5

@bors
Copy link
Collaborator

bors commented Sep 28, 2025

📌 Commit f4032bc has been approved by matthiaskrgr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 28, 2025
@bors
Copy link
Collaborator

bors commented Sep 28, 2025

⌛ Testing commit f4032bc with merge a00a515...

@bors
Copy link
Collaborator

bors commented Sep 28, 2025

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing a00a515 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 28, 2025
@bors bors merged commit a00a515 into rust-lang:master Sep 28, 2025
11 checks passed
@rustbot rustbot added this to the 1.92.0 milestone Sep 28, 2025
Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 4ffeda1 (parent) -> a00a515 (this PR)

Test differences

Show 4 test diffs

Stage 1

  • [ui] tests/ui/traits/next-solver/cycles/ignore-head-usages-provisional-cache.rs: [missing] -> pass (J0)

Stage 2

  • [ui] tests/ui/traits/next-solver/cycles/ignore-head-usages-provisional-cache.rs: [missing] -> pass (J1)

Additionally, 2 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard a00a5159cfac23e9b1551566cf71ff31edc1f11b --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-android: 1305.0s -> 1518.4s (16.4%)
  2. dist-x86_64-windows-gnullvm: 5679.3s -> 4938.2s (-13.0%)
  3. dist-aarch64-apple: 5935.5s -> 6503.4s (9.6%)
  4. dist-various-1: 3894.2s -> 4249.6s (9.1%)
  5. dist-arm-linux-musl: 6095.1s -> 5590.6s (-8.3%)
  6. dist-x86_64-apple: 6404.8s -> 6910.6s (7.9%)
  7. dist-s390x-linux: 5199.1s -> 4802.6s (-7.6%)
  8. x86_64-gnu-debug: 6513.2s -> 6991.6s (7.3%)
  9. pr-check-1: 1363.8s -> 1456.1s (6.8%)
  10. aarch64-gnu-llvm-20-2: 2178.8s -> 2319.9s (6.5%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#142139 Include additional hashes in src/stage0 556e4c9b0c9a65b1d9e91291884824558d9c5801 (link)
#146745 Clarified error note for usize range matching 9f136dd123509b78353400cae3ef2e11133cbfb4 (link)
#146763 cg_llvm: Replace some DIBuilder wrappers with LLVM-C API bi… 540f0e41eccf4b9d78e29913ed57b1c834eaa1d9 (link)
#146788 chore: removes deprecated discord. 3be9e9ede3c8aab96eebcbf837254ad24da68edc (link)
#146942 [rustdoc] Finish getting rid of usages write_str 99b73fdba08786bd0001c96ab1214aa98ba0ae04 (link)
#147061 fix rebasing cycle heads when not reaching a fixpoint fd3e3cfcd2fae7da02fd650710ae64bcb8ff9e66 (link)
#147066 Fix tracking issue number for feature(macro_attr) c85e0a46956eb6165e970c6529a8e768ca2573dc (link)
#147081 doc: fix a typo in platform-support.md 0fd9401541e438d8b731fea4d517c8119cc5a7f8 (link)
#147082 formatting_options: fix alternate docs 0b/0o mixup 920b62dfa4f9e9b74c3b5a32cd2108e3e6b7e113 (link)
#147086 compiletest: Use PanicHookInfo::payload_as_str now that i… 508e8a32bb182a267069358611320b8329679390 (link)
#147093 redox: switch to colon as path separator a8bf87ccceb4a3bf119a1a4e6b35ec6e77821763 (link)
#147095 Library: Remove remaining private #[repr] workarounds 76f6a1dcdf8d2a45b6bdfb5d7f07dbde57794c17 (link)
#147098 Add auto extra-checks in pre-push hook 8407cb7135d4af9db784bda696685214bf8ca069 (link)
#147110 Fix typo 3129ce292326b3859c3a51291d0d0ed500519881 (link)

previous master: 4ffeda10e1

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (a00a515): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -3.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-3.7% [-4.9%, -2.4%] 2
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -3.7% [-4.9%, -2.4%] 2

Cycles

Results (primary -3.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-3.1% [-3.1%, -3.1%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -3.1% [-3.1%, -3.1%] 1

Binary size

Results (secondary 0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.0% [0.0%, 0.0%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Bootstrap: 469.714s -> 470.329s (0.13%)
Artifact size: 387.67 MiB -> 387.69 MiB (0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-compiletest Area: The compiletest test runner A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-meta Area: Issues & PRs about the rust-lang/rust repository itself A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. O-unix Operating system: Unix-like rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-release Relevant to the release subteam, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)
Projects
None yet
Development

Successfully merging this pull request may close these issues.