Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Expose fmt::Arguments::from_str as unstable. #148906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Expose fmt::Arguments::from_str as unstable. #148906

wants to merge 1 commit into from
+18 −11

Conversation

@m-ou-se
Copy link
Member

@m-ou-se m-ou-se commented Nov 13, 2025

Now that #148789 is merged, we can have a fmt::Arguments::from_str. I don't know if we want to commit to always having an implementation that allows for this, but we can expose it as unstable for now so we can play with it.

Tracking issue: #148905

@m-ou-se m-ou-se added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. A-fmt Area: `core::fmt` labels Nov 13, 2025
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 13, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 13, 2025

r? @scottmcm

rustbot has assigned @scottmcm.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

This was referenced Nov 13, 2025
Closed
Closed
dtolnay
dtolnay approved these changes Nov 13, 2025
View reviewed changes
Copy link
Member

@dtolnay dtolnay left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

View changes since this review

@dtolnay
Copy link
Member

dtolnay commented Nov 13, 2025

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 13, 2025

📌 Commit ad1789a has been approved by dtolnay

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 13, 2025
@dtolnay dtolnay assigned dtolnay and unassigned scottmcm Nov 13, 2025
This was referenced Nov 13, 2025
Open
Open
Zalathar added a commit to Zalathar/rust that referenced this pull request Nov 13, 2025
@Zalathar
Rollup merge of rust-lang#148906 - m-ou-se:fmt-args-from-str, r=dtolnay
d4c2129 
Expose fmt::Arguments::from_str as unstable.

Now that rust-lang#148789 is merged, we can have a fmt::Arguments::from_str. I don't know if we want to commit to always having an implementation that allows for this, but we can expose it as unstable for now so we can play with it.

Tracking issue: rust-lang#148905
@Zalathar Zalathar mentioned this pull request Nov 13, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dtolnay dtolnay dtolnay approved these changes

Assignees

@dtolnay dtolnay

Labels

A-fmt Area: `core::fmt` S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@m-ou-se @rustbot @dtolnay @bors @scottmcm