Never return an error after a partial write #32107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If LineWriter fails to flush, return the number of bytes written instead of an error. Fixes rust-lang#32085
|
As this technically changes the behavior of LineWriter, this is a breaking change. How/should I label it? |
|
Thanks! I think it's fine to call this a bugfix rather than a breaking change. Can you be sure to add a test for this though? |
|
@alexcrichton done. |
bors
added a commit
that referenced
this pull request
Mar 10, 2016
Never return an error after a partial write If LineWriter fails to flush, return the number of bytes written instead of an error. Fixes #32085
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If LineWriter fails to flush, return the number of bytes written instead
of an error.
Fixes #32085