Thanks to visit codestin.com
Credit goes to github.com

Skip to content

'label can start expressions #50155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 28, 2018
Merged

'label can start expressions #50155

merged 2 commits into from
Apr 28, 2018

Conversation

est31
Copy link
Member

@est31 est31 commented Apr 22, 2018 

let foo = 'label: loop { break 'label 42; };

is valid Rust code.

@rust-highfive
Copy link
Contributor

r? @petrochenkov

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 22, 2018
petrochenkov
petrochenkov reviewed Apr 22, 2018
View reviewed changes
src/libsyntax/parse/token.rs Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add NtLifetime here as well?

This also needs a test, something like return 'label: loop {} will start parsing with Lifetime(..) being able to start an expression.

@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 22, 2018
est31 added 2 commits April 23, 2018 11:17
@est31
'label can start expressions
40f2ca2 
let foo = 'label: loop { break 'label 42; };

is valid Rust code.
@est31
Add tests
edee60d
@est31 est31 force-pushed the label_expressions branch from a63f224 to edee60d Compare April 23, 2018 15:53
@est31
Copy link
Member Author

est31 commented Apr 24, 2018

r? @petrochenkov

@kennytm kennytm added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 24, 2018
@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Apr 25, 2018

📌 Commit edee60d has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 25, 2018
@bors
Copy link
Collaborator

bors commented Apr 28, 2018

⌛ Testing commit edee60d with merge ff65726...

bors added a commit that referenced this pull request Apr 28, 2018
@bors
Auto merge of #50155 - est31:label_expressions, r=petrochenkov
ff65726 
'label can start expressions

```Rust
let foo = 'label: loop { break 'label 42; };
```

is valid Rust code.
@bors
Copy link
Collaborator

bors commented Apr 28, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: petrochenkov
Pushing ff65726 to master...

@bors bors merged commit edee60d into rust-lang:master Apr 28, 2018
This was referenced Apr 28, 2018
Merged
Merged
@dtolnay dtolnay mentioned this pull request Jun 10, 2018
Closed
@lqd lqd mentioned this pull request Jul 17, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petrochenkov petrochenkov petrochenkov left review comments

Assignees

@petrochenkov petrochenkov

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@est31 @rust-highfive @petrochenkov @bors @kennytm