Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Crate store cleanup #52927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 4, 2018
Merged

Crate store cleanup #52927

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d4beeca
Move validate_crate_name to rustc_metadata
Mark-Simulacrum Jul 31, 2018
cc1a6b9
Delete dummy crate store
Mark-Simulacrum Jul 31, 2018
eb0bc64
Visibility is now a query
Mark-Simulacrum Jul 31, 2018
5aec365
Store concrete crate stores where possible
Mark-Simulacrum Jul 31, 2018
6fdd6f6
Move unused trait functions to inherent functions
Mark-Simulacrum Jul 31, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Visibility is now a query
  • Loading branch information
@Mark-Simulacrum
Mark-Simulacrum committed Aug 3, 2018
commit eb0bc642653519f5b8ab460e3d5bb4bff1e58753
1 change: 0 additions & 1 deletion src/librustc/middle/cstore.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,6 @@ pub trait CrateStore {
fn def_path_table(&self, cnum: CrateNum) -> Lrc<DefPathTable>;

// "queries" used in resolve that aren't tracked for incremental compilation
fn visibility_untracked(&self, def: DefId) -> ty::Visibility;
fn export_macros_untracked(&self, cnum: CrateNum);
fn dep_kind_untracked(&self, cnum: CrateNum) -> DepKind;
fn crate_name_untracked(&self, cnum: CrateNum) -> Symbol;
Expand Down
4 changes: 0 additions & 4 deletions src/librustc_metadata/cstore_impl.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -420,10 +420,6 @@ impl CrateStore for cstore::CStore {
&*self.metadata_loader
}

fn visibility_untracked(&self, def: DefId) -> ty::Visibility {
self.get_crate_data(def.krate).get_visibility(def.index)
}

fn item_generics_cloned_untracked(&self, def: DefId, sess: &Session) -> ty::Generics {
self.get_crate_data(def.krate).get_generics(def.index, sess)
}
Expand Down