Thanks to visit codestin.com
Credit goes to github.com

Skip to content

optimize redundant borrows and escaping paths in NLL #53177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Aug 10, 2018
Merged

optimize redundant borrows and escaping paths in NLL #53177

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
fb1702f
compute liveness later
nikomatsakis Aug 7, 2018
db7a07c
update comment to more accurately describe the limitations
nikomatsakis Aug 7, 2018
5147d38
promote liveness to a directory module
nikomatsakis Aug 7, 2018
d1ce8e8
move `liveness_map` into the `liveness` module
nikomatsakis Aug 7, 2018
a92bf8d
liveness_map: rustfmt
nikomatsakis Aug 7, 2018
887296e
make it possible to customize the `RegionGraph` direction
nikomatsakis Aug 7, 2018
3b7989d
avoid computing liveness when a variable doesn't need it
nikomatsakis Aug 7, 2018
1bae4f5
optimize redundant borrows
nikomatsakis Aug 7, 2018
ff7f6d5
don't walk MIR if no local variables need liveness
nikomatsakis Aug 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
don't walk MIR if no local variables need liveness 
This is true for tuple-stress and html5ever
  • Loading branch information
@nikomatsakis
nikomatsakis committed Aug 10, 2018
commit ff7f6d57de1112805272bae57ff5918d4f25e0ab
5 changes: 5 additions & 0 deletions src/librustc_mir/borrow_check/nll/type_check/liveness/liveness_map.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,11 @@ impl NllLivenessMap {
to_local,
}
}

/// True if there are no local variables that need liveness computation.
crate fn is_empty(&self) -> bool {
self.to_local.is_empty()
}
}

/// Index given to each local variable whose type contains a region.
Expand Down
2 changes: 1 addition & 1 deletion src/librustc_mir/borrow_check/nll/type_check/liveness/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ pub(super) fn generate<'gcx, 'tcx>(
let liveness = LivenessResults::compute(mir, &liveness_map);

// For everything else, it is only live where it is actually used.
{
if !liveness_map.is_empty() {
let mut generator = TypeLivenessGenerator {
cx,
mir,
Expand Down