Explain type mismatch cause pointing to return type when it is impl Trait
#57793
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
|
r? @oli-obk |
oli-obk
reviewed
Jan 21, 2019
| | | ---- expected because of this statement | ||
| | | ---- ...is found to be `i32` here | ||
| LL | | } else { | ||
| LL | | 1u32 |
There was a problem hiding this comment.
Mostly unrelated to this PR, but shouldn't the type mismatch span point to this 1u32 instead of the entire if expression?
There was a problem hiding this comment.
I've made a few changes recently to point at the tail expression in blocks instead of entire blocks, but haven't finished yet. This change is already in my plans :)
oli-obk
reviewed
Jan 21, 2019
|
@bors r+ |
|
📌 Commit ab2479b has been approved by |
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jan 23, 2019
Explain type mismatch cause pointing to return type when it is `impl Trait` Fix rust-lang#57743.
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jan 23, 2019
Explain type mismatch cause pointing to return type when it is `impl Trait` Fix rust-lang#57743.
bors
added a commit
that referenced
this pull request
Jan 24, 2019
Rollup of 11 pull requests Successful merges: - #57179 (Update std/lib.rs docs to reflect Rust 2018 usage) - #57730 (Merge visitors in AST validation) - #57779 (Recover from parse errors in literal struct fields and incorrect float literals) - #57793 (Explain type mismatch cause pointing to return type when it is `impl Trait`) - #57795 (Use structured suggestion in stead of notes) - #57817 (Add error for trailing angle brackets.) - #57834 (Stabilize Any::get_type_id and rename to type_id) - #57836 (Fix some cross crate existential type ICEs) - #57840 (Fix issue 57762) - #57844 (use port 80 for retrieving GPG key) - #57858 (Ignore line ending on older git versions) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #57743.