Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

crlf0710
Copy link
Member

@crlf0710 crlf0710 commented Apr 4, 2019

No description provided.

@rust-highfive
Copy link
Contributor

r? @estebank

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 4, 2019
@crlf0710
Copy link
Member Author

crlf0710 commented Apr 4, 2019

This is a temporary workaround for #59674
This (hopefully) unblocks #59500.

@crlf0710
Copy link
Member Author

crlf0710 commented Apr 4, 2019

r? @sanxiyn

@rust-highfive rust-highfive assigned sanxiyn and unassigned estebank Apr 4, 2019
@crlf0710 crlf0710 force-pushed the disable_gnux32_stackprobe branch from 9772daf to 42d652e Compare April 4, 2019 06:40
@crlf0710
Copy link
Member Author

crlf0710 commented Apr 4, 2019

Addressed the review comment above :)

@luqmana
Copy link
Contributor

luqmana commented Apr 4, 2019

@bors r+

@bors
Copy link
Collaborator

bors commented Apr 4, 2019

📌 Commit 42d652e has been approved by luqmana

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 4, 2019
Centril added a commit to Centril/rust that referenced this pull request Apr 4, 2019
… r=luqmana

Temporarily disable stack probing for gnux32.
Centril added a commit to Centril/rust that referenced this pull request Apr 4, 2019
… r=luqmana

Temporarily disable stack probing for gnux32.
Centril added a commit to Centril/rust that referenced this pull request Apr 4, 2019
… r=luqmana

Temporarily disable stack probing for gnux32.
Centril added a commit to Centril/rust that referenced this pull request Apr 4, 2019
… r=luqmana

Temporarily disable stack probing for gnux32.
Centril added a commit to Centril/rust that referenced this pull request Apr 4, 2019
… r=luqmana

Temporarily disable stack probing for gnux32.
bors added a commit that referenced this pull request Apr 4, 2019
Rollup of 8 pull requests

Successful merges:

 - #59470 (Document std::fs::File close behavior ignoring errors)
 - #59555 (update miri)
 - #59556 (update stdsimd)
 - #59596 (Forward formatter settings to bounds of `Range<T>` in `fmt::Debug` impl)
 - #59639 (Never return uninhabited values at all)
 - #59671 (Make some of lexer's API private)
 - #59685 (Add description for -Os and -Oz in rustc.1)
 - #59686 (Temporarily disable stack probing for gnux32.)

Failed merges:

r? @ghost
@bors bors merged commit 42d652e into rust-lang:master Apr 4, 2019
@crlf0710 crlf0710 deleted the disable_gnux32_stackprobe branch April 4, 2019 18:48
Centril added a commit to Centril/rust that referenced this pull request Jul 21, 2019
Revert "Disable stack probing for gnux32."

This reverts commit 42d652e. (rust-lang#59686)

Closes rust-lang#59674.
Centril added a commit to Centril/rust that referenced this pull request Jul 22, 2019
Revert "Disable stack probing for gnux32."

This reverts commit 42d652e. (rust-lang#59686)

Closes rust-lang#59674.
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Jul 23, 2019
Revert "Disable stack probing for gnux32."

This reverts commit 42d652e. (rust-lang#59686)

Closes rust-lang#59674.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants