Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add APIs for uninitialized Box, Rc, and Arc. (Plus get_mut_unchecked) #62451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Aug 18, 2019
Merged

Add APIs for uninitialized Box, Rc, and Arc. (Plus get_mut_unchecked) #62451

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
1613fda
Add Rc::get_mut_unchecked, Arc::get_mut_unchecked
SimonSapin Jul 6, 2019
7b02b9f
Add new_uninit and assume_init on Box, Rc, and Arc
SimonSapin Jul 6, 2019
bde1924
Add new_uninit_slice and assume_init on Box, Rc, and Arc of [T]
SimonSapin Jul 6, 2019
170d933
Move constructors of boxed/rc’ed slices to matching `impl` blocks
SimonSapin Jul 6, 2019
4eeb623
Fix intra-rustdoc links
SimonSapin Jul 6, 2019
dab967a
Use `alloc::Global` in `Box::new_uninit`
SimonSapin Jul 16, 2019
1141136
Use ManuallyDrop instead of mem::forget
SimonSapin Jul 16, 2019
78264f5
Add tracking issue numbers
SimonSapin Aug 5, 2019
ae1e201
Add a comment on the usage of Layout::new::<RcBox<()>>()
SimonSapin Aug 5, 2019
810dfd7
Reuse more internal Rc and Arc methods
SimonSapin Aug 16, 2019
7a641f7
Relax the safety condition for get_mut_unchecked
SimonSapin Aug 16, 2019
ba03283
Doc nits
SimonSapin Aug 17, 2019
b79ce1b
Rename private helper method allocate_for_unsized to allocate_for_layout
SimonSapin Aug 17, 2019
9bd7083
Doc nit
SimonSapin Aug 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add a comment on the usage of Layout::new::<RcBox<()>>()
  • Loading branch information
@SimonSapin
SimonSapin committed Aug 16, 2019
commit ae1e201a0cd37a48bd3dabf1c643ccd5f53f7680
2 changes: 2 additions & 0 deletions src/liballoc/rc.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -441,6 +441,8 @@ impl<T> Rc<[T]> {
#[unstable(feature = "new_uninit", issue = "63291")]
pub fn new_uninit_slice(len: usize) -> Rc<[mem::MaybeUninit<T>]> {
let data_layout = Layout::array::<mem::MaybeUninit<T>>(len).unwrap();
// This relies on `value` being the last field of `RcBox` in memory,
// so that the layout of `RcBox<T>` is the same as that of `RcBox<()>` followed by `T`.
let (layout, offset) = Layout::new::<RcBox<()>>().extend(data_layout).unwrap();
unsafe {
let allocated_ptr = Global.alloc(layout)
Expand Down
2 changes: 2 additions & 0 deletions src/liballoc/sync.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -425,6 +425,8 @@ impl<T> Arc<[T]> {
#[unstable(feature = "new_uninit", issue = "63291")]
pub fn new_uninit_slice(len: usize) -> Arc<[mem::MaybeUninit<T>]> {
let data_layout = Layout::array::<mem::MaybeUninit<T>>(len).unwrap();
// This relies on `value` being the last field of `RcBox` in memory,
// so that the layout of `RcBox<T>` is the same as that of `RcBox<()>` followed by `T`.
let (layout, offset) = Layout::new::<ArcInner<()>>().extend(data_layout).unwrap();
unsafe {
let allocated_ptr = Global.alloc(layout)
Expand Down