Thanks to visit codestin.com
Credit goes to github.com

Skip to content

tests: Require run-pass tests without annotations to run successfully again #62797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 22, 2019
Merged

tests: Require run-pass tests without annotations to run successfully again #62797

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
14f5160
tests: Require run-pass tests without annotations to run successfully…
petrochenkov Jul 19, 2019
39d144e
Fix or ignore regressed tests
petrochenkov Jul 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
tests: Require run-pass tests without annotations to run successfully… 
… again
  • Loading branch information
@petrochenkov
petrochenkov committed Jul 22, 2019
commit 14f51604230dcc77ea2b360b743c59b51126f3a4
4 changes: 3 additions & 1 deletion src/tools/compiletest/src/runtest.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,8 +318,10 @@ impl<'test> TestCx<'test> {
}

fn should_run_successfully(&self) -> bool {
let pass_mode = self.pass_mode();
match self.config.mode {
RunPass | Ui => self.pass_mode() == Some(PassMode::Run),
Ui => pass_mode == Some(PassMode::Run),
RunPass => pass_mode == Some(PassMode::Run) || pass_mode.is_none(),
mode => panic!("unimplemented for mode {:?}", mode),
}
}
Expand Down