Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Rust 2015: No longer downgrade NLL errors #64221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Sep 27, 2019
Merged

Rust 2015: No longer downgrade NLL errors #64221

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
ece6f83
Refuse downgrading NLL errors on Rust 2015.
Centril Sep 6, 2019
aff9c83
rustc_mir: remove dead code for downgrading errors.
Centril Sep 6, 2019
6ec9b3a
Adjust & --bless tests due to no longer downgrading NLL errors on 2015.
Centril Sep 6, 2019
487f8ab
add test for #53432.
Centril Sep 6, 2019
2fb0bba
remove feature(nll) from #45157 test.
Centril Sep 6, 2019
1256613
remove feature(nll) from #31567 test.
Centril Sep 6, 2019
b638aa1
remove feature(nll) from #27868 test.
Centril Sep 6, 2019
2b80ed9
remove feature(nll) in more cases.
Centril Sep 6, 2019
dfdd4d7
rm "src/test/ui/issues/issue-45696-scribble-on-boxed-borrow.migrate.s…
Centril Sep 25, 2019
ce8c5d2
issue-#45696-scribble...: remove outdated comment.
Centril Sep 25, 2019
f8af766
cargotest: bump webrender
Centril Sep 26, 2019
9a2cc54
cargotest: bump iron
Centril Sep 26, 2019
5a0e461
issue-#45696: remove ignore-compare-mode-nll
Centril Sep 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
issue-#45696: remove ignore-compare-mode-nll
  • Loading branch information
@Centril
Centril committed Sep 26, 2019
commit 5a0e4613ce62f1e46f974af4065e5ccb3f56a1af
9 changes: 3 additions & 6 deletions src/test/ui/issues/issue-45696-scribble-on-boxed-borrow.nll.stderr
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,33 +1,30 @@
error[E0713]: borrow may still be in use when destructor runs
--> $DIR/issue-45696-scribble-on-boxed-borrow.rs:52:5
--> $DIR/issue-45696-scribble-on-boxed-borrow.rs:34:5
|
LL | fn scribbled<'a>(s: Scribble<'a>) -> &'a mut u32 {
| -- lifetime `'a` defined here
LL | &mut *s.0
| ^^^^^^^^^ returning this value requires that `*s.0` is borrowed for `'a`
...
LL | }
| - here, drop of `s` needs exclusive access to `*s.0`, because the type `Scribble<'_>` implements the `Drop` trait

error[E0713]: borrow may still be in use when destructor runs
--> $DIR/issue-45696-scribble-on-boxed-borrow.rs:63:5
--> $DIR/issue-45696-scribble-on-boxed-borrow.rs:39:5
|
LL | fn boxed_scribbled<'a>(s: Box<Scribble<'a>>) -> &'a mut u32 {
| -- lifetime `'a` defined here
LL | &mut *(*s).0
| ^^^^^^^^^^^^ returning this value requires that `*s.0` is borrowed for `'a`
...
LL | }
| - here, drop of `s` needs exclusive access to `*s.0`, because the type `Scribble<'_>` implements the `Drop` trait

error[E0713]: borrow may still be in use when destructor runs
--> $DIR/issue-45696-scribble-on-boxed-borrow.rs:74:5
--> $DIR/issue-45696-scribble-on-boxed-borrow.rs:44:5
|
LL | fn boxed_boxed_scribbled<'a>(s: Box<Box<Scribble<'a>>>) -> &'a mut u32 {
| -- lifetime `'a` defined here
LL | &mut *(**s).0
| ^^^^^^^^^^^^^ returning this value requires that `*s.0` is borrowed for `'a`
...
LL | }
| - here, drop of `s` needs exclusive access to `*s.0`, because the type `Scribble<'_>` implements the `Drop` trait

Expand Down
1 change: 0 additions & 1 deletion src/test/ui/issues/issue-45696-scribble-on-boxed-borrow.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
// mutable borrows that would be scribbled over by destructors before
// the return occurs.

// ignore-compare-mode-nll
// ignore-compare-mode-polonius

struct Scribble<'a>(&'a mut u32);
Expand Down
6 changes: 3 additions & 3 deletions src/test/ui/issues/issue-45696-scribble-on-boxed-borrow.stderr
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
error[E0713]: borrow may still be in use when destructor runs
--> $DIR/issue-45696-scribble-on-boxed-borrow.rs:35:5
--> $DIR/issue-45696-scribble-on-boxed-borrow.rs:34:5
|
LL | fn scribbled<'a>(s: Scribble<'a>) -> &'a mut u32 {
| -- lifetime `'a` defined here
Expand All @@ -9,7 +9,7 @@ LL | }
| - here, drop of `s` needs exclusive access to `*s.0`, because the type `Scribble<'_>` implements the `Drop` trait

error[E0713]: borrow may still be in use when destructor runs
--> $DIR/issue-45696-scribble-on-boxed-borrow.rs:40:5
--> $DIR/issue-45696-scribble-on-boxed-borrow.rs:39:5
|
LL | fn boxed_scribbled<'a>(s: Box<Scribble<'a>>) -> &'a mut u32 {
| -- lifetime `'a` defined here
Expand All @@ -19,7 +19,7 @@ LL | }
| - here, drop of `s` needs exclusive access to `*s.0`, because the type `Scribble<'_>` implements the `Drop` trait

error[E0713]: borrow may still be in use when destructor runs
--> $DIR/issue-45696-scribble-on-boxed-borrow.rs:45:5
--> $DIR/issue-45696-scribble-on-boxed-borrow.rs:44:5
|
LL | fn boxed_boxed_scribbled<'a>(s: Box<Box<Scribble<'a>>>) -> &'a mut u32 {
| -- lifetime `'a` defined here
Expand Down