Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Do not ICE in if without else in async fn #66391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 15, 2019
Merged

Do not ICE in if without else in async fn #66391

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7d61484
Do not ICE in `if` without `else` in `async fn`
estebank Nov 13, 2019
c0a0a7d
review comments
estebank Nov 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
review comments
  • Loading branch information
@estebank
estebank committed Nov 14, 2019
commit c0a0a7d711b89d89e04a135d6035a2881a7de72e
2 changes: 1 addition & 1 deletion src/librustc_typeck/check/generator_interior.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,7 @@ impl<'a, 'tcx> Visitor<'tcx> for InteriorVisitor<'a, 'tcx> {
// If this were not the case, then we could conceivably have
// to create intermediate temporaries.)
//
// The type table might not have invormation for this expression
// The type table might not have information for this expression
// if it is in a malformed scope. (#66387)
if let Some(ty) = self.fcx.tables.borrow().expr_ty_opt(expr) {
self.record(ty, scope, Some(expr), expr.span);
Expand Down
2 changes: 2 additions & 0 deletions src/test/ui/async-await/issue-66387-if-without-else.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ async fn f() -> i32 {
if true { //~ ERROR if may be missing an else clause
return 0;
}
// An `if` block without `else` causes the type table not to have a type for this expr.
// Check that we do not unconditionally access the type table and we don't ICE.
}

fn main() {}