Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add str::strip_prefix and str::strip_suffix #66735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 16, 2019
Merged

Add str::strip_prefix and str::strip_suffix #66735

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9badc33
Add str::strip_prefix and str::strip_suffix
SOF3 Nov 25, 2019
2e2e0df
Improved comments to clarify sasumptions in str::strip_prefix
SOF3 Nov 26, 2019
4718e20
Fixed formatting issues
SOF3 Nov 26, 2019
6176051
Set tracking issue for str_strip
SOF3 Dec 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Improved comments to clarify sasumptions in str::strip_prefix
  • Loading branch information
@SOF3
SOF3 committed Nov 26, 2019
commit 2e2e0dfc1acfb69be9575d320418d04f3caf64a7
12 changes: 7 additions & 5 deletions src/libcore/str/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3797,7 +3797,7 @@ impl str {
/// the prefix is removed. Unlike `trim_start_matches`, this method removes the prefix exactly
/// once.
///
/// If the string does not start with `prefix`, it is removed.
/// If the string does not start with `prefix`, `None` is returned.
///
/// # Examples
///
Expand All @@ -3814,8 +3814,9 @@ impl str {
pub fn strip_prefix<'a, P: Pattern<'a>>(&'a self, prefix: P) -> Option<&'a str> {
let mut matcher = prefix.into_searcher(self);
if let SearchStep::Match(start, len) = matcher.next() {
debug_assert_eq!(start, 0);
debug_assert_eq!(start, 0, "The first search step from Searcher must start from the front");
unsafe {
// Searcher is known to return valid indices.
Some(self.get_unchecked(len..))
}
} else {
Expand All @@ -3825,11 +3826,11 @@ impl str {

/// Returns a string slice with the suffix removed.
///
/// If the string starts with the pattern `suffix`, `Some` is returned with the substring where
/// If the string ends with the pattern `suffix`, `Some` is returned with the substring where
/// the suffix is removed. Unlike `trim_end_matches`, this method removes the suffix exactly
/// once.
///
/// If the string does not start with `suffix`, it is removed.
/// If the string does not end with `suffix`, `None` is returned.
///
/// # Examples
///
Expand All @@ -3849,8 +3850,9 @@ impl str {
{
let mut matcher = suffix.into_searcher(self);
if let SearchStep::Match(start, end) = matcher.next_back() {
debug_assert_eq!(end, self.len());
debug_assert_eq!(end, self.len(), "The first search step from ReverseSearcher must include the last character");
unsafe {
// Searcher is known to return valid indices.
Some(self.get_unchecked(..start))
}
} else {
Expand Down