Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Enable loop and while in constants behind a feature flag #67216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Dec 15, 2019
Merged

Enable loop and while in constants behind a feature flag #67216

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
8f3021b
Get active features dynamically by their `Symbol`
ecstatic-morse Dec 10, 2019
57959b2
Add feature gate for `const_loop`
ecstatic-morse Dec 10, 2019
8f59902
Put MIR checks for loops behind the feature flag
ecstatic-morse Dec 10, 2019
ee233c0
Restructue HIR const-checker to handle features with multiple gates
ecstatic-morse Dec 10, 2019
99e132d
Extend control flow basics tests with loops
ecstatic-morse Dec 11, 2019
1122404
Add qualif smoke tests for const loops
ecstatic-morse Dec 11, 2019
caa7c99
Bless unrelated tests with new help message
ecstatic-morse Dec 11, 2019
3325671
Bless modified tests
ecstatic-morse Dec 11, 2019
2add77d
Improve message when active feature indexing panics
ecstatic-morse Dec 11, 2019
a8e997c
Improve comment
ecstatic-morse Dec 11, 2019
a2a0774
Look for "unstable feature" error code in test
ecstatic-morse Dec 11, 2019
b3aecd0
Fix grammar in test description
ecstatic-morse Dec 11, 2019
2b5ae1c
Apply suggestions from review
ecstatic-morse Dec 11, 2019
80581be
Replace `Index` impl with `enabled` method
ecstatic-morse Dec 11, 2019
34ce0ba
Use better name for local containing required feature gates
ecstatic-morse Dec 11, 2019
598bed6
Ensure test actually uses dataflow, not simulation
ecstatic-morse Dec 11, 2019
029725f
Use correct nightly version for feature
ecstatic-morse Dec 11, 2019
0f0bfc9
Document `Features::enabled`
ecstatic-morse Dec 12, 2019
faa52d1
Correctly mark things as `min_const_fn`
ecstatic-morse Dec 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Improve comment
  • Loading branch information
@ecstatic-morse
ecstatic-morse committed Dec 13, 2019
commit a8e997c819cc3cb9c70062da93809cd6f2540a0a
4 changes: 2 additions & 2 deletions src/librustc_passes/check_const.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,8 @@ impl NonConstExpr {
| Self::Match(WhileLetDesugar)
=> &[sym::const_loop, sym::const_if_match],

// `for` loops desugar to a call to `FromIterator::from_iterator`,
// so they are not yet supported behind a feature flag.
// A `for` loop's desugaring contains a call to `FromIterator::from_iter`,
// so they are not yet allowed with `#![feature(const_loop)]`.
_ => return None,
};

Expand Down