Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Make our pattern matching logic undestand &[T] constants #70699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Make our pattern matching logic undestand &[T] constants #70699

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0a80624
Fixup comments and clarify ICEs
oli-obk Dec 27, 2019
2aa0bfd
Handle slice "deref" in pattern matching.
oli-obk Apr 2, 2020
7c4984f
Update src/librustc_mir_build/hair/pattern/_match.rs
oli-obk Apr 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update src/librustc_mir_build/hair/pattern/_match.rs 
Co-Authored-By: varkor <[email protected]>
  • Loading branch information
@oli-obk @varkor
oli-obk and varkor authored Apr 2, 2020
commit 7c4984ffc63c3c1fd7a39b2a42d3f31d5034e32d
5 changes: 3 additions & 2 deletions src/librustc_mir_build/hair/pattern/_match.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,8 +297,9 @@ impl<'tcx> LiteralExpander<'tcx> {
}
}
}
// Unsize array to slice if pattern is array
// but match value or other patterns are slice.
// Unsize the array to a slice if we're matching on a slice,
// or other patterns are a slice (despite this pattern being
// an array).
(ConstValue::Scalar(s), ty::Array(t, n), ty::Slice(u)) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to avoid these one-letter variable names.

assert_eq!(t, u);
let n = n.eval_usize(self.tcx, ty::ParamEnv::empty()).try_into().unwrap();
Expand Down