Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Be less aggressive with DroplessArena/TypedArena growth. #71872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 16, 2020
Merged

Be less aggressive with DroplessArena/TypedArena growth. #71872

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9111d8b
Fix the new capacity measurement in arenas.
nnethercote May 4, 2020
40d4868
Be less aggressive with `DroplessArena`/`TypedArena` growth.
nnethercote May 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix the new capacity measurement in arenas. 
For the given code paths, the amount of space used in the previous chunk
is irrelevant.

(This will almost never make a difference to behaviour, but it makes the
code clearer.)
  • Loading branch information
@nnethercote
nnethercote committed May 13, 2020
commit 9111d8b66e013a881bae4e09646514be86ca4c87
4 changes: 2 additions & 2 deletions src/libarena/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ impl<T> TypedArena<T> {
new_capacity = last_chunk.storage.capacity();
loop {
new_capacity = new_capacity.checked_mul(2).unwrap();
if new_capacity >= currently_used_cap + n {
if new_capacity >= n {
break;
}
}
Expand Down Expand Up @@ -350,7 +350,7 @@ impl DroplessArena {
new_capacity = last_chunk.storage.capacity();
loop {
new_capacity = new_capacity.checked_mul(2).unwrap();
if new_capacity >= used_bytes + needed_bytes {
if new_capacity >= needed_bytes {
break;
}
}
Expand Down