Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Warn about unused captured variables #72465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 29, 2020
Merged

Warn about unused captured variables #72465

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3f13d97
liveness: Log information about used variables
tmiasko May 20, 2020
b3342b4
liveness: Remove unused clean_exit_var
tmiasko May 21, 2020
7c63014
liveness: Remove unused fallthrough_ln
tmiasko May 21, 2020
74fcbfb
liveness: Include upvars in the analysis
tmiasko May 21, 2020
4dc5661
liveness: Warn about unused captured variables
tmiasko May 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
liveness: Log information about used variables
  • Loading branch information
@tmiasko
tmiasko committed May 29, 2020
commit 3f13d97d275c806ea6616071566d8c4f875f18a8
13 changes: 8 additions & 5 deletions src/librustc_passes/liveness.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,7 +357,7 @@ fn visit_fn<'tcx>(
sp: Span,
id: hir::HirId,
) {
debug!("visit_fn");
debug!("visit_fn {:?}", id);

// swap in a new set of IR maps for this function body:
let def_id = ir.tcx.hir().local_def_id(id);
Expand Down Expand Up @@ -777,12 +777,12 @@ impl<'a, 'tcx> Liveness<'a, 'tcx> {

fn write_vars<F>(&self, wr: &mut dyn Write, ln: LiveNode, mut test: F) -> io::Result<()>
where
F: FnMut(usize) -> LiveNode,
F: FnMut(usize) -> bool,
{
let node_base_idx = self.idx(ln, Variable(0));
for var_idx in 0..self.ir.num_vars {
let idx = node_base_idx + var_idx;
if test(idx).is_valid() {
if test(idx) {
write!(wr, " {:?}", Variable(var_idx as u32))?;
}
}
Expand All @@ -795,9 +795,12 @@ impl<'a, 'tcx> Liveness<'a, 'tcx> {
{
let wr = &mut wr as &mut dyn Write;
write!(wr, "[ln({:?}) of kind {:?} reads", ln.get(), self.ir.lnk(ln));
self.write_vars(wr, ln, |idx| self.rwu_table.get_reader(idx));
self.write_vars(wr, ln, |idx| self.rwu_table.get_reader(idx).is_valid());
write!(wr, " writes");
self.write_vars(wr, ln, |idx| self.rwu_table.get_writer(idx));
self.write_vars(wr, ln, |idx| self.rwu_table.get_writer(idx).is_valid());
write!(wr, " uses");
self.write_vars(wr, ln, |idx| self.rwu_table.get_used(idx));

write!(wr, " precedes {:?}]", self.successors[ln.get()]);
}
String::from_utf8(wr).unwrap()
Expand Down