Thanks to visit codestin.com
Credit goes to github.com

Skip to content

linker: MSVC supports linking static libraries as a whole archive #72785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 19, 2020
Merged

linker: MSVC supports linking static libraries as a whole archive #72785

merged 1 commit into from
Jun 19, 2020

Conversation

petrochenkov
Copy link
Contributor

No description provided.

@rust-highfive
Copy link
Contributor

r? @matthewjasper

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 30, 2020
@Elinvynia Elinvynia added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 10, 2020
@matthewjasper
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 11, 2020

📌 Commit d1c275b has been approved by matthewjasper

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 11, 2020
RalfJung added a commit to RalfJung/rust that referenced this pull request Jun 12, 2020
@RalfJung
Rollup merge of rust-lang#72785 - petrochenkov:wholemsvc, r=matthewja…
97ae4f6 
…sper

linker: MSVC supports linking static libraries as a whole archive
@RalfJung RalfJung mentioned this pull request Jun 12, 2020
Closed
@RalfJung RalfJung mentioned this pull request Jun 19, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 19, 2020
@bors
Auto merge of rust-lang#73504 - RalfJung:rollup-iy8hsvl, r=RalfJung
72417d8 
Rollup of 10 pull requests

Successful merges:

 - rust-lang#72280 (Fix up autoderef when reborrowing)
 - rust-lang#72785 (linker: MSVC supports linking static libraries as a whole archive)
 - rust-lang#73011 (first stage of implementing LLVM code coverage)
 - rust-lang#73044 (compiletest: Add directives to detect sanitizer support)
 - rust-lang#73054 (memory access sanity checks: abort instead of panic)
 - rust-lang#73136 (Change how compiler-builtins gets many CGUs)
 - rust-lang#73280 (Add E0763)
 - rust-lang#73317 (bootstrap: read config from $RUST_BOOTSTRAP_CONFIG)
 - rust-lang#73350 (bootstrap/install.rs: support a nonexistent `prefix` in `x.py install`)
 - rust-lang#73352 (Speed up bootstrap a little.)

Failed merges:

r? @ghost
@bors bors merged commit 7cc4518 into rust-lang:master Jun 19, 2020
@pragmatrix pragmatrix mentioned this pull request Jul 19, 2020
Merged
@kornelski
Copy link
Contributor

kornelski commented Oct 9, 2020 •
edited
Loading

@petrochenkov There has been a user report that this change broke MSVC builds:

cl
Compilateur d'optimisation Microsoft (R) C/C++ version 19.26.28806 pour x64
Copyright (C) Microsoft Corporation. Tous droits réservés.

link
Microsoft (R) Incremental Linker Version 14.26.28806.0
Copyright (C) Microsoft Corporation. All rights reserved.

@petrochenkov
Copy link
Contributor Author

petrochenkov commented Oct 9, 2020 •
edited
Loading

@kornelski
Thanks for reporting.
Details like this are not really documented so it's hard to rely on them and promise stability.
Once rust-lang/compiler-team#356 is approved and implemented, it will provide explicit control over behavior of --whole-archive//WHOLEARCHIVE, and we'll document the defaults as well.
This PR at least makes those defaults consistent across platforms.

@bmarcaur bmarcaur mentioned this pull request Feb 26, 2021
Closed
FaultyRAM added a commit to FaultyRAM/windres-rs that referenced this pull request Feb 26, 2021
@FaultyRAM
MSVC: remove =static from Cargo link command
8f8a9e1 
rust-lang/rust#72785 introduced a breaking
change for MSVC targets that causes linking against a static library to
fail when using `cargo:rustc-link-lib=static`. As a workaround, remove
`=static` from the MSVC code until Rust allows disabling whole archive
linking.
@petrochenkov petrochenkov mentioned this pull request May 3, 2021
Merged
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request May 7, 2021
@Dylan-DPC
Rollup merge of rust-lang#84866 - petrochenkov:wholesome, r=Mark-Simu…
e33bcf1 
…lacrum

linker: Avoid library duplication with `/WHOLEARCHIVE`

Looks like in rust-lang#72785 I misinterpreted how the `link.exe`'s `/WHOLEARCHIVE` flag works.

It's not necessary to write `mylib /WHOLEARCHIVE:mylib` to mark `mylib` as whole archive, `/WHOLEARCHIVE:mylib` alone is enough.

https://docs.microsoft.com/en-us/cpp/build/reference/wholearchive-include-all-library-object-files?view=msvc-160
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request May 7, 2021
@Dylan-DPC
Rollup merge of rust-lang#84866 - petrochenkov:wholesome, r=Mark-Simu…
ee5ea17 
…lacrum

linker: Avoid library duplication with `/WHOLEARCHIVE`

Looks like in rust-lang#72785 I misinterpreted how the `link.exe`'s `/WHOLEARCHIVE` flag works.

It's not necessary to write `mylib /WHOLEARCHIVE:mylib` to mark `mylib` as whole archive, `/WHOLEARCHIVE:mylib` alone is enough.

https://docs.microsoft.com/en-us/cpp/build/reference/wholearchive-include-all-library-object-files?view=msvc-160
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request May 7, 2021
@Dylan-DPC
Rollup merge of rust-lang#84866 - petrochenkov:wholesome, r=Mark-Simu…
6e4c842 
…lacrum

linker: Avoid library duplication with `/WHOLEARCHIVE`

Looks like in rust-lang#72785 I misinterpreted how the `link.exe`'s `/WHOLEARCHIVE` flag works.

It's not necessary to write `mylib /WHOLEARCHIVE:mylib` to mark `mylib` as whole archive, `/WHOLEARCHIVE:mylib` alone is enough.

https://docs.microsoft.com/en-us/cpp/build/reference/wholearchive-include-all-library-object-files?view=msvc-160
@petrochenkov petrochenkov mentioned this pull request May 10, 2021
Closed
@petrochenkov petrochenkov mentioned this pull request Feb 16, 2022
Merged
@sagudev sagudev mentioned this pull request Apr 20, 2023
Closed
@petrochenkov petrochenkov deleted the wholemsvc branch February 22, 2025 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@matthewjasper matthewjasper

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@petrochenkov @rust-highfive @matthewjasper @bors @kornelski @Elinvynia