Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Make CTFE able to check for UB... #78407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Jan 12, 2021
Merged

Make CTFE able to check for UB... #78407

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
68ff5f0
Stop optimizing promoteds
Oct 20, 2020
552f391
Make `encode_optimized_mir` always perform its action and instead req…
Oct 21, 2020
dadf937
Remove mir encode calls that didn't actually encode anything
Oct 26, 2020
248b4db
Limit trait item mir encoding to items with default bodies
Oct 26, 2020
8e4fe66
Require the `encode_promoted_mir` caller to know whether MIR for this…
Oct 26, 2020
cccd40f
Keep an unoptimized duplicate of `const fn` around
Oct 26, 2020
1f5fb3e
Differentiate between the availability of ctfe MIR and runtime MIR
oli-obk Oct 28, 2020
eb4e94b
Simplify the `optimize_mir` query
oli-obk Oct 28, 2020
db90150
Polymorphization should look at the runtime MIR of `const fn`
oli-obk Dec 7, 2020
680c402
Comment nit
oli-obk Dec 7, 2020
7202054
Document all the things
oli-obk Dec 7, 2020
f6d54aa
Adjust imports
oli-obk Dec 7, 2020
caeb3d5
Move MIR body loading to a machine function
oli-obk Dec 7, 2020
9eaec13
Small comment adjustments
oli-obk Dec 26, 2020
a76dae4
Fix wording of query description
oli-obk Dec 26, 2020
3af7989
No doc comments on expressions
oli-obk Dec 26, 2020
409195d
Update stderr files after rebase
oli-obk Dec 26, 2020
65ee418
Do not run const prop on the `mir_for_ctfe` of `const fn`
oli-obk Jan 4, 2021
41a732d
Remove a FIXME and explain the decision
oli-obk Jan 5, 2021
e90b521
--emit=mir now emits both `mir_for_ctfe` and `optimized_mir` for `con…
oli-obk Jan 11, 2021
53e3a23
Coverage computation needs access to the MIR, too
oli-obk Jan 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Polymorphization should look at the runtime MIR of const fn
  • Loading branch information
@oli-obk
oli-obk committed Jan 4, 2021
commit db90150b91c1b3402e1a1419f857031c94fb074e
9 changes: 4 additions & 5 deletions compiler/rustc_mir/src/monomorphize/polymorphize.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ fn unused_generic_params(tcx: TyCtxt<'_>, def_id: DefId) -> FiniteBitSet<u32> {
// Exit early when there is no MIR available.
let context = tcx.hir().body_const_context(def_id.expect_local());
match context {
None if !tcx.is_mir_available(def_id) => {
Some(ConstContext::Fn) | None if !tcx.is_mir_available(def_id) => {
debug!("unused_generic_params: (no mir available) def_id={:?}", def_id);
return FiniteBitSet::new_empty();
}
Expand All @@ -78,10 +78,9 @@ fn unused_generic_params(tcx: TyCtxt<'_>, def_id: DefId) -> FiniteBitSet<u32> {

// Visit MIR and accumululate used generic parameters.
let body = match context {
None => tcx.optimized_mir(def_id),
// FIXME(oli-obk): since this is solely used for codegen (I think?), should we keep using
// the optimized MIR for `const fn`? Need to adjust the above `is_mir_available` check
// in that case.
// Const functions are actually called and should thus be considered for polymorphization
// via their runtime MIR
Some(ConstContext::Fn) | None => tcx.optimized_mir(def_id),
Some(_) => tcx.mir_for_ctfe(def_id),
};
let mut vis = MarkUsedGenericParams { tcx, def_id, unused_parameters: &mut unused_parameters };
Expand Down