Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Rollup of 9 pull requests #78693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 36 commits into from
Closed

Rollup of 9 pull requests #78693

Changes from 1 commit
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
06fe278
Fix unindent behavior between different doc comments
GuillaumeGomez Oct 26, 2020
b4c3536
Add test for doc comments unindent fix
GuillaumeGomez Oct 26, 2020
f3e6d88
Fix typos and replace static vector with slice
bugadani Oct 28, 2020
a21f3a7
Clean up encode_dep_graph
bugadani Oct 28, 2020
5248b20
Reuse memory
bugadani Oct 28, 2020
2fa3598
Avoid reallocating cgu_path_components
bugadani Oct 28, 2020
a8803d3
Delete files immediately, instead of collecting into vector
bugadani Oct 28, 2020
6bbb7fd
Change a bit how the first doc comment lines are handled
GuillaumeGomez Oct 29, 2020
fcee70f
Update tests
GuillaumeGomez Oct 29, 2020
ad27894
Move compiletest meta tests to a separate directory
tmiasko Oct 30, 2020
affb47f
Add a test for compiletest rustc-env & unset-rustc-env directives
tmiasko Oct 30, 2020
289c0d8
Retagging: do not retag 'raw reborrows'
RalfJung Oct 31, 2020
fef9c63
Rust coverage before splitting instrument_coverage.rs
richkadel Oct 5, 2020
0bb09c1
Splitting transform/instrument_coverage.rs into transform/coverage/...
richkadel Oct 23, 2020
7b87ae4
Implemented CoverageGraph of BasicCoverageBlocks
richkadel Oct 23, 2020
af0c84c
Adds coverage graphviz
richkadel Oct 23, 2020
868de57
Injecting expressions in place of counters where helpful
richkadel Oct 22, 2020
da20b67
Added comments on remapping expression IDs, and URL to spanviews
richkadel Oct 25, 2020
0edf4a5
Addressed all feedback to date
richkadel Oct 25, 2020
3685689
Responded to all feedback as of 2020-10-30
richkadel Oct 30, 2020
87f2897
Improve code in unindent_comment a bit more
GuillaumeGomez Nov 1, 2020
c0cbf63
inliner: Remove redundant loop
tmiasko Nov 2, 2020
a8dfb26
Document -Zinstrument-coverage
richkadel Oct 31, 2020
c83c635
Fix intrinsic size_of stable link
pickfire Nov 2, 2020
e78e9d4
Treat trailing semicolon as a statement in macro call
Aaron1011 Oct 25, 2020
6d94911
addressed feedback
richkadel Nov 2, 2020
3d7baee
fix cross-platform test bugs
richkadel Nov 2, 2020
974c03d
Rollup merge of #78267 - richkadel:llvm-coverage-counters-2.0.3r1, r=…
Dylan-DPC Nov 3, 2020
3a110ef
Rollup merge of #78376 - Aaron1011:feature/consistent-empty-expr, r=p…
Dylan-DPC Nov 3, 2020
1425ac0
Rollup merge of #78400 - GuillaumeGomez:fix-unindent, r=jyn514
Dylan-DPC Nov 3, 2020
01e7c01
Rollup merge of #78489 - bugadani:array, r=estebank
Dylan-DPC Nov 3, 2020
5f0c9c1
Rollup merge of #78575 - tmiasko:compiletest-rustc-env, r=Aaron1011
Dylan-DPC Nov 3, 2020
8088713
Rollup merge of #78597 - RalfJung:raw-retag, r=oli-obk
Dylan-DPC Nov 3, 2020
d56e305
Rollup merge of #78616 - richkadel:unstable-book-instr-cov, r=tmandry
Dylan-DPC Nov 3, 2020
bb3ef75
Rollup merge of #78664 - pickfire:patch-4, r=jonas-schievink
Dylan-DPC Nov 3, 2020
04245d1
Rollup merge of #78668 - tmiasko:inline, r=oli-obk
Dylan-DPC Nov 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix typos and replace static vector with slice
  • Loading branch information
@bugadani
bugadani committed Oct 28, 2020
commit f3e6d882fec61ef290b9097f896cfbcf39f5b4bd
16 changes: 8 additions & 8 deletions compiler/rustc_incremental/src/persist/dirty_clean.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ pub fn check_dirty_clean_annotations(tcx: TyCtxt<'_>) {

let mut all_attrs = FindAllAttrs {
tcx,
attr_names: vec![sym::rustc_dirty, sym::rustc_clean],
attr_names: &[sym::rustc_dirty, sym::rustc_clean],
found_attrs: vec![],
};
intravisit::walk_crate(&mut all_attrs, krate);
Expand Down Expand Up @@ -299,7 +299,7 @@ impl DirtyCleanVisitor<'tcx> {

// Represents a Trait Declaration
// FIXME(michaelwoerister): trait declaration is buggy because sometimes some of
// the depnodes don't exist (because they legitametely didn't need to be
// the depnodes don't exist (because they legitimately didn't need to be
// calculated)
//
// michaelwoerister and vitiral came up with a possible solution,
Expand Down Expand Up @@ -512,17 +512,17 @@ fn expect_associated_value(tcx: TyCtxt<'_>, item: &NestedMetaItem) -> Symbol {
}

// A visitor that collects all #[rustc_dirty]/#[rustc_clean] attributes from
// the HIR. It is used to verfiy that we really ran checks for all annotated
// the HIR. It is used to verify that we really ran checks for all annotated
// nodes.
pub struct FindAllAttrs<'tcx> {
pub struct FindAllAttrs<'a, 'tcx> {
tcx: TyCtxt<'tcx>,
attr_names: Vec<Symbol>,
attr_names: &'a [Symbol],
found_attrs: Vec<&'tcx Attribute>,
}

impl FindAllAttrs<'tcx> {
impl FindAllAttrs<'_, 'tcx> {
fn is_active_attr(&mut self, attr: &Attribute) -> bool {
for attr_name in &self.attr_names {
for attr_name in self.attr_names {
if self.tcx.sess.check_name(attr, *attr_name) && check_config(self.tcx, attr) {
return true;
}
Expand All @@ -543,7 +543,7 @@ impl FindAllAttrs<'tcx> {
}
}

impl intravisit::Visitor<'tcx> for FindAllAttrs<'tcx> {
impl intravisit::Visitor<'tcx> for FindAllAttrs<'_, 'tcx> {
type Map = Map<'tcx>;

fn nested_visit_map(&mut self) -> intravisit::NestedVisitorMap<Self::Map> {
Expand Down