Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Don't abort rustdoc tests if tidy isn't installed #79370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 12, 2020
Merged

Don't abort rustdoc tests if tidy isn't installed #79370

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
409382d
Don't abort rustdoc tests if `tidy` isn't installed
jyn514 Nov 24, 2020
804b72a
If tidy isn't installed, only give one error, not many
jyn514 Nov 26, 2020
f9b97a8
Ignore .css files in the diff
jyn514 Nov 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Ignore .css files in the diff 
These are always static and never autogenerated, so the diffs aren't
useful.
  • Loading branch information
@jyn514
jyn514 committed Dec 12, 2020
commit f9b97a8e458b73b7e670a940877f91f9ce0b9ce3
3 changes: 2 additions & 1 deletion src/tools/compiletest/src/runtest.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2437,7 +2437,8 @@ impl<'test> TestCx<'test> {
})
};
let mut diff = Command::new("diff");
diff.args(&["-u", "-r"]).args(&[&compare_dir, out_dir]);
// diff recursively, showing context, and excluding .css files
diff.args(&["-u", "-r", "-x", "*.css"]).args(&[&compare_dir, out_dir]);

let output = if let Some(pager) = pager {
let diff_pid = diff.stdout(Stdio::piped()).spawn().expect("failed to run `diff`");
Expand Down