Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Uplift the invalid_atomic_ordering lint from clippy to rustc #79654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

Uplift the invalid_atomic_ordering lint from clippy to rustc #79654

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
5d8c4be
Uplift the `invalid_atomic_ordering` lint from clippy to rustc
thomcc Dec 2, 2020
5d59e7a
Truncate overlong error lines for tidy's sake
thomcc Dec 3, 2020
4a9aaa0
Mark failing lint example as compile_fail
thomcc Dec 3, 2020
e517634
Undo the change that incorrectly deprecated the clippy lint
thomcc Dec 3, 2020
ace2c5d
ignore rustc's invalid_atomic_ordering lint in the clippy lint tests …
thomcc Dec 3, 2020
ee38c89
Deprecate clippy::invalid_atomic_ordering
flip1995 Dec 9, 2020
a02f7b7
Teach rustc_diagnostic_item that enums have variants
thomcc Dec 10, 2020
844329c
Use rustc_diagnostic_item for the orderings in the invalid_atomic_ord…
thomcc Dec 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Teach rustc_diagnostic_item that enums have variants
  • Loading branch information
@thomcc
thomcc committed Dec 10, 2020
commit a02f7b72b67f35f242cbbc9c9bba3c1977305d83
6 changes: 6 additions & 0 deletions compiler/rustc_passes/src/diagnostic_items.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,12 @@ struct DiagnosticItemCollector<'tcx> {
impl<'v, 'tcx> ItemLikeVisitor<'v> for DiagnosticItemCollector<'tcx> {
fn visit_item(&mut self, item: &hir::Item<'_>) {
self.observe_item(&item.attrs, item.hir_id);

if let hir::ItemKind::Enum(e, _) = &item.kind {
for variant in e.variants {
self.observe_item(variant.attrs, variant.id);
}
}
}

fn visit_trait_item(&mut self, trait_item: &hir::TraitItem<'_>) {
Expand Down