Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Shorten html::render #82088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 5, 2021
Merged

Shorten html::render #82088

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
48167c4
Moved Context and its impls to a separate file
Nicholas-Baron Feb 14, 2021
6c7d7a6
Moved `print_item` and helpers to a separate file
Nicholas-Baron Feb 14, 2021
14983b9
Moved the `make_item_keywords` function to `context.rs` as it is only…
Nicholas-Baron Feb 14, 2021
fd14e38
Moved `write_shared` to its own file
Nicholas-Baron Feb 14, 2021
afb8220
Corrected imports for render tests and mod files
Nicholas-Baron Feb 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Moved the make_item_keywords function to context.rs as it is only… 
… used there
  • Loading branch information
@Nicholas-Baron
Nicholas-Baron committed Mar 4, 2021
commit 14983b9812e67a283587b651c0a14e1d4e1ab723
8 changes: 6 additions & 2 deletions src/librustdoc/html/render/context.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ use rustc_span::symbol::sym;
use super::cache::{build_index, ExternalLocation};
use super::print_item::{full_path, item_path, print_item};
use super::{
make_item_keywords, print_sidebar, settings, write_shared, AllTypes, NameDoc, SharedContext,
StylePath, BASIC_KEYWORDS, CURRENT_DEPTH, INITIAL_IDS,
print_sidebar, settings, AllTypes, NameDoc, SharedContext, StylePath, BASIC_KEYWORDS,
CURRENT_DEPTH, INITIAL_IDS,
};

use crate::clean::{self, AttributesExt};
Expand Down Expand Up @@ -610,3 +610,7 @@ impl<'tcx> FormatRenderer<'tcx> for Context<'tcx> {
&self.cache
}
}

fn make_item_keywords(it: &clean::Item) -> String {
format!("{}, {}", BASIC_KEYWORDS, it.name.as_ref().unwrap())
}
3 changes: 0 additions & 3 deletions src/librustdoc/html/render/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2924,9 +2924,6 @@ fn sidebar_foreign_type(cx: &Context<'_>, buf: &mut Buffer, it: &clean::Item) {

crate const BASIC_KEYWORDS: &str = "rust, rustlang, rust-lang";

fn make_item_keywords(it: &clean::Item) -> String {
format!("{}, {}", BASIC_KEYWORDS, it.name.as_ref().unwrap())
}

/// Returns a list of all paths used in the type.
/// This is used to help deduplicate imported impls
Expand Down