Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix underflow in specialized ZipImpl::size_hint #82289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 5, 2021
Merged

Fix underflow in specialized ZipImpl::size_hint #82289

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
66a2606
Increment self.len in specialized ZipImpl to avoid underflow in size_…
SkiFire13 Feb 19, 2021
8b9ac4d
Add test for underflow in specialized Zip's size_hint
SkiFire13 Feb 19, 2021
aeb4ea7
Remove useless comparison since now self.index <= self.len is an inva…
SkiFire13 Feb 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Increment self.len in specialized ZipImpl to avoid underflow in size_… 
…hint
  • Loading branch information
@SkiFire13
SkiFire13 committed Mar 3, 2021
commit 66a260617a88ed1ad55a46f03c5a90d5ad3004d3
1 change: 1 addition & 0 deletions library/core/src/iter/adapters/zip.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,7 @@ where
} else if A::MAY_HAVE_SIDE_EFFECT && self.index < self.a.size() {
let i = self.index;
self.index += 1;
self.len += 1;
// match the base implementation's potential side effects
// SAFETY: we just checked that `i` < `self.a.len()`
unsafe {
Expand Down