Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix ICE caused by non_exaustive_omitted_patterns struct lint #89423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 5, 2021
Merged

Fix ICE caused by non_exaustive_omitted_patterns struct lint #89423

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8cbcc89
Fix ICE caused by non_exaustive_omitted_patterns struct lint
DevinR528 Oct 1, 2021
f7a8980
Reorder etc check for non_exhaustive_omitted_patterns
DevinR528 Oct 2, 2021
3d83ff6
Add ui test for empty fields for omitted_patterns lint
DevinR528 Oct 2, 2021
b06409e
Rename etc -> has_rest_pat
DevinR528 Oct 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Reorder etc check for non_exhaustive_omitted_patterns
  • Loading branch information
@DevinR528
DevinR528 committed Oct 2, 2021
commit f7a8980347f83d2602161e5617c5af4c06d80747
15 changes: 8 additions & 7 deletions compiler/rustc_typeck/src/check/pat.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1286,13 +1286,8 @@ impl<'a, 'tcx> FnCtxt<'a, 'tcx> {
field.vis.is_accessible_from(tcx.parent_module(pat.hir_id).to_def_id(), tcx)
})
.collect();
if non_exhaustive && !accessible_unmentioned_fields.is_empty() {
self.lint_non_exhaustive_omitted_patterns(
pat,
&accessible_unmentioned_fields,
adt_ty,
)
} else if !etc {

if !etc {
if accessible_unmentioned_fields.is_empty() {
unmentioned_err = Some(self.error_no_accessible_fields(pat, fields));
} else {
Expand All @@ -1303,6 +1298,12 @@ impl<'a, 'tcx> FnCtxt<'a, 'tcx> {
fields,
));
}
} else if non_exhaustive && !accessible_unmentioned_fields.is_empty() {
self.lint_non_exhaustive_omitted_patterns(
pat,
&accessible_unmentioned_fields,
adt_ty,
)
}
}
match (inexistent_fields_err, unmentioned_err) {
Expand Down